Skip to content

Commit 8721e08

Browse files
committed
change constructor param of gson serializer
1 parent b82cd15 commit 8721e08

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

clients/graphql-kotlin-client-gson/src/main/kotlin/com/expediagroup/graphql/client/gson/GraphQLClientGsonSerializer.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import com.expediagroup.graphql.client.types.GraphQLClientError
2121
import com.expediagroup.graphql.client.types.GraphQLClientRequest
2222
import com.expediagroup.graphql.client.types.GraphQLClientResponse
2323
import com.expediagroup.graphql.client.types.GraphQLClientSourceLocation
24-
import com.google.gson.Gson
24+
import com.google.gson.GsonBuilder
2525
import com.google.gson.JsonArray
2626
import com.google.gson.JsonParser.parseString
2727
import com.google.gson.reflect.TypeToken
@@ -51,7 +51,7 @@ data class GsonGraphQLResponse<T>(
5151
* Gson based GraphQL request/response serializer.
5252
*/
5353
class GraphQLClientGsonSerializer(
54-
private val gson: Gson = Gson()
54+
gsonBuilder: GsonBuilder = GsonBuilder().serializeNulls()
5555
) : GraphQLClientSerializer {
5656

5757
private val typeCache = ConcurrentHashMap<KClass<*>, Type>()
@@ -61,6 +61,8 @@ class GraphQLClientGsonSerializer(
6161
TypeToken.getParameterized(GsonGraphQLResponse::class.java, type.java).type
6262
}
6363

64+
private val gson = gsonBuilder.create()
65+
6466
override fun serialize(request: GraphQLClientRequest<*>): String = gson.toJson(request)
6567

6668
override fun serialize(requests: List<GraphQLClientRequest<*>>): String = gson.toJson(requests)

clients/graphql-kotlin-client-gson/src/test/kotlin/com/expediagroup/graphql/client/gson/GraphQLClientGsonSerializerTest.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,14 @@ package com.expediagroup.graphql.client.gson
1919
import com.expediagroup.graphql.client.gson.data.*
2020
import com.expediagroup.graphql.client.gson.data.enums.TestEnum
2121
import com.expediagroup.graphql.client.gson.data.polymorphicquery.SecondInterfaceImplementation
22-
import com.google.gson.GsonBuilder
2322
import com.google.gson.JsonParser
2423
import org.junit.jupiter.api.Test
2524
import java.util.*
2625
import kotlin.test.assertEquals
2726

2827
class GraphQLClientGsonSerializerTest {
2928

30-
private val gson = GsonBuilder().serializeNulls().create()
31-
private val serializer = GraphQLClientGsonSerializer(gson)
29+
private val serializer = GraphQLClientGsonSerializer()
3230

3331
@Test
3432
fun `verify we can serialize GraphQLClientRequest`() {

0 commit comments

Comments
 (0)