Merge pull request #170 from Workiva/react-18-test

FED-3275 React 18 Prep

Author: btr-rmconsole-1[bot]

lib/src/over_react_test/common_component_util.dart

@@ -585,9 +585,11 @@ void testRequiredProps(BuilderOnlyUiFactory factory, dynamic childrenFactory())
       final originalConsoleError = context['console']['error'] as JsFunction;
       addTearDown(() => context['console']['error'] = originalConsoleError);
       context['console']['error'] = JsFunction.withThis((self, [message, arg1, arg2, arg3,  arg4, arg5]) {
-        consoleErrors.add(message);
-        originalConsoleError.apply([message, arg1, arg2, arg3,  arg4, arg5],
-            thisArg: self);
+        if(!shouldFilterOutLog(message)) {
+          consoleErrors.add(message);
+          originalConsoleError
+              .apply([message, arg1, arg2, arg3, arg4, arg5], thisArg: self);
+        }
       });
 
       final reactComponentFactory = factory().componentFactory as
@@ -662,9 +664,11 @@ void testRequiredProps(BuilderOnlyUiFactory factory, dynamic childrenFactory())
       final originalConsoleError = context['console']['error'] as JsFunction;
       addTearDown(() => context['console']['error'] = originalConsoleError);
       context['console']['error'] = JsFunction.withThis((self, [message, arg1, arg2, arg3,  arg4, arg5]) {
-        consoleErrors.add(message);
-        originalConsoleError.apply([message, arg1, arg2, arg3,  arg4, arg5],
-            thisArg: self);
+        if(!shouldFilterOutLog(message)) {
+          consoleErrors.add(message);
+          originalConsoleError
+              .apply([message, arg1, arg2, arg3, arg4, arg5], thisArg: self);
+        }
       });
 
       final reactComponentFactory = factory().componentFactory as

lib/src/over_react_test/console_log_utils.dart

@@ -17,6 +17,11 @@ import 'dart:js';
 
 import 'package:react/react_client/react_interop.dart';
 
+/// Intercept console.error calls and silence warnings for each react_dom.render call,
+/// until at the very least createRoot is made available in react-dart.
+bool shouldFilterOutLog(String log) =>
+    log.startsWith('Warning: ReactDOM.render is no longer supported in React 18.');
+
 /// Runs a provided callback and returns the logs that occur during the runtime
 /// of that function.
 ///
@@ -51,11 +56,13 @@ List<String?> recordConsoleLogs(
     consoleRefs[config] = context['console'][config];
     context['console'][config] =
         JsFunction.withThis((self, [message, arg1, arg2, arg3, arg4, arg5]) {
-      // NOTE: Using console.log or print within this function will cause an infinite
-      // loop when the logType is set to `log`.
-      consoleLogs.add(message);
-      consoleRefs[config]!
-          .apply([message, arg1, arg2, arg3, arg4, arg5], thisArg: self);
+          if(!shouldFilterOutLog(message)) {
+            // NOTE: Using console.log or print within this function will cause an infinite
+            // loop when the logType is set to `log`.
+            consoleLogs.add(message);
+            consoleRefs[config]!
+                .apply([message, arg1, arg2, arg3, arg4, arg5], thisArg: self);
+          }
     });
   }
 
@@ -98,11 +105,13 @@ FutureOr<List<String?>> recordConsoleLogsAsync(
     consoleRefs[config] = context['console'][config];
     context['console'][config] =
         JsFunction.withThis((self, [message, arg1, arg2, arg3, arg4, arg5]) {
-      // NOTE: Using console.log or print within this function will cause an infinite
-      // loop when the logType is set to `log`.
-      consoleLogs.add(message);
-      consoleRefs[config]!
-          .apply([message, arg1, arg2, arg3, arg4, arg5], thisArg: self);
+          if(!shouldFilterOutLog(message)) {
+            // NOTE: Using console.log or print within this function will cause an infinite
+            // loop when the logType is set to `log`.
+            consoleLogs.add(message);
+            consoleRefs[config]!
+                .apply([message, arg1, arg2, arg3, arg4, arg5], thisArg: self);
+          }
     });
   }