re-enable langdetect field store attribute, set default to true

Author: jprante

gradle.properties

@@ -1,6 +1,6 @@
 group = org.xbib.elasticsearch.plugin
 name = elasticsearch-langdetect
-version = 5.4.0.0
+version = 5.4.0.1
 
 elasticsearch.version = 5.4.0
 log4j.version = 2.8.2

src/main/java/org/xbib/elasticsearch/index/mapper/langdetect/LangdetectMapper.java

@@ -435,7 +435,7 @@ public static class TypeParser implements Mapper.TypeParser {
         }
 
         private static boolean parseStore(String store) throws MapperParsingException {
-            return !"no".equals(store) && ("yes".equals(store) || lenientNodeBooleanValue(null, store, false));
+            return !"no".equals(store) && ("yes".equals(store) || lenientNodeBooleanValue(null, store, true));
         }
     }
 

src/test/java/org/xbib/elasticsearch/index/mapper/langdetect/LangdetectMappingTest.java

@@ -68,6 +68,20 @@ public void testCustomMappings() throws Exception {
         assertEquals("Deutsch", doc.getFields("someField")[0].stringValue());
     }
 
+    @Test
+    public void testStoreMappings() throws Exception {
+        Settings settings = Settings.builder()
+                .put("path.home", System.getProperty("path.home"))
+                .loadFromStream("settings.json", getClass().getResourceAsStream("settings.json")).build();
+        String mapping = copyToStringFromClasspath("mapping-stored.json");
+        DocumentMapper docMapper = MapperTestUtils.newDocumentMapperParser(settings, "someIndex").parse("someType", new CompressedXContent(mapping));
+        String sampleText = copyToStringFromClasspath("german.txt");
+        BytesReference json = jsonBuilder().startObject().field("someField", sampleText).endObject().bytes();
+        ParseContext.Document doc = docMapper.parse("someIndex", "someType", "1", json).rootDoc();
+        assertEquals(1, doc.getFields("someField").length);
+        assertTrue(doc.getFields("someField")[0].fieldType().stored());
+    }
+
     @Test
     public void testBinary2() throws Exception {
         String mapping = copyToStringFromClasspath("base64-2-mapping.json");

src/test/resources/org/xbib/elasticsearch/index/mapper/langdetect/mapping-stored.json

@@ -0,0 +1,14 @@
+{
+  "someType" : {
+    "properties" : {
+      "someField":{
+        "type" : "langdetect",
+        "store": true,
+        "languages" : [ "de", "en", "fr", "nl", "it" ],
+        "map" : {
+          "de" : "Deutsch"
+        }
+      }
+    }
+  }
+}