Release of version 1.4.3

Missing javadoc added to avoid Maven warning and build failure during the release.

Author: h3xstream

findbugs-test-util/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <groupId>com.h3xstream.findsecbugs</groupId>
         <artifactId>findsecbugs-root-pom</artifactId>
-        <version>1.4.3-SNAPSHOT</version>
+        <version>1.4.3</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 

plugin-deps/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <groupId>com.h3xstream.findsecbugs</groupId>
         <artifactId>findsecbugs-root-pom</artifactId>
-        <version>1.4.3-SNAPSHOT</version>
+        <version>1.4.3</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 

plugin/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <groupId>com.h3xstream.findsecbugs</groupId>
         <artifactId>findsecbugs-root-pom</artifactId>
-        <version>1.4.3-SNAPSHOT</version>
+        <version>1.4.3</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 

plugin/src/main/java/com/h3xstream/findsecbugs/common/ByteCode.java

@@ -75,7 +75,7 @@ public static void printOpCode(Instruction ins, ConstantPoolGen cpg) {
      * @param h Instruction Handle
      * @param cpg Constant Pool
      * @param clazz Type of the constant being read
-     * @return
+     * @return The constant value if any is found
      */
     public static <T> T getConstantLDC(InstructionHandle h, ConstantPoolGen cpg, Class<T> clazz) {
         Instruction prevIns = h.getInstruction();
@@ -105,7 +105,7 @@ public static Integer getConstantInt(InstructionHandle h) {
      * Extract the number from a push operation (BIPUSH/SIPUSH).
      *
      * @param h Instruction Handle
-     * @return
+     * @return The constant number if any is found
      */
     public static Number getPushNumber(InstructionHandle h) {
         Instruction prevIns = h.getInstruction();
@@ -122,9 +122,9 @@ public static Number getPushNumber(InstructionHandle h) {
     /**
      * Get the previous instruction matching the given type of instruction (second parameter)
      *
-     * @param startHandle
-     * @param clazz       Type of instruction to look for
-     * @return
+     * @param startHandle Location to start from
+     * @param clazz Type of instruction to look for
+     * @return The instruction found (null if not found)
      */
     public static <T> T getPrevInstruction(InstructionHandle startHandle, Class<T> clazz) {
         InstructionHandle curHandle = startHandle;

plugin/src/main/java/com/h3xstream/findsecbugs/injection/InjectionSource.java

@@ -29,7 +29,7 @@ public interface InjectionSource {
      * its constant pool gen. All classes dependencies can be found in this pool.
      *
      * @param cpg
-     * @return
+     * @return If the current class need to be analyzed.
      */
     boolean isCandidate(ConstantPoolGen cpg);
 
@@ -40,7 +40,7 @@ public interface InjectionSource {
      * @param ins       Instruction visit
      * @param cpg       ConstantPool (needed to find the class name and method name associate to instruction)
      * @param insHandle instruction handle (needed to look at the instruction around the current instruction)
-     * @return
+     * @return Precision about the parameter at risk for the current instruction visit. (InjectionPoint.NONE when the method is safe)
      */
     InjectionPoint getInjectableParameters(InvokeInstruction ins, ConstantPoolGen cpg, InstructionHandle insHandle);
 

plugin/src/main/java/com/h3xstream/findsecbugs/injection/TaintDetector.java

@@ -198,7 +198,8 @@ private void reportBug(BugInstance bugInstance, Taint taint, String currentMetho
 
     private void delayBugToReport(String method, Taint taint, BugInstance bug) {
         TaintSink taintSink = new TaintSink(taint, bug);
-        Set<TaintSink> sinkSet = methodsWithSinks.getOrDefault(method, new HashSet<TaintSink>());
+        Set<TaintSink> sinkSet = methodsWithSinks.get(method);
+        if(sinkSet == null) sinkSet = new HashSet<TaintSink>();
         sinkSet.add(taintSink);
         methodsWithSinks.put(method, sinkSet);
     }

pom.xml

@@ -7,7 +7,7 @@
     <artifactId>findsecbugs-root-pom</artifactId>
 
     <packaging>pom</packaging>
-    <version>1.4.3-SNAPSHOT</version>
+    <version>1.4.3</version>
 
     <name>Find Security Bugs root</name>
 

website/pom.xml

@@ -6,7 +6,7 @@
     <parent>
         <groupId>com.h3xstream.findsecbugs</groupId>
         <artifactId>findsecbugs-root-pom</artifactId>
-        <version>1.4.3-SNAPSHOT</version>
+        <version>1.4.3</version>
     </parent>
 
     <modelVersion>4.0.0</modelVersion>