Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: iCamilo/ios-lead-essentials-feed-api-challenge
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: aamayorga/iOS-Lead-Essentials-FeedAPI-Challenge
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 3 files changed
  • 1 contributor

Commits on Jun 18, 2020

  1. Test to make sure if we make a GET request, in our RemoteFeedLoader, … 

    …that we load our URL twice if it is called twice
    @aamayorga
    aamayorga committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    f47db78 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. Deliver network error when we complete our request with client error

    @aamayorga
    aamayorga committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    1ea033a View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. Return an invalid data error if the HTTP response isn't 200

    @aamayorga
    aamayorga committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    4309f70 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Deliver an invalid data error on 200 HTTP Response with Invalid JSON

    @aamayorga
    aamayorga committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    241f4e9 View commit details
    Browse the repository at this point in the history

  2. Deliver success with no items on 200 HTTP Response with empty JSON list

    @aamayorga
    aamayorga committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    4976ac3 View commit details
    Browse the repository at this point in the history

  3. Deliver success with mapped JSON items on 200 HTTP response given JSO… 

    …N items
    @aamayorga
    aamayorga committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    b82bc66 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. Refactored code to take CodingKeys out of model and into the RemoteFe… 

    …edLoader implementation.

Moved mapping logic into its own function.
    @aamayorga
    aamayorga committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    7e1b174 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. Make sure that SUT instance doesn't deliver a result after it has bee… 

    …n deallocated
    @aamayorga
    aamayorga committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    114442f View commit details
    Browse the repository at this point in the history

  2. Added clarity to status code response numbers

    @aamayorga
    aamayorga committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    17fba2d View commit details
    Browse the repository at this point in the history
Loading