Skip to content

Commit 71681a1

Browse files
committed
remove FlagEncoder variable from abstract algo classes
1 parent 6344ed5 commit 71681a1

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

core/src/main/java/com/graphhopper/routing/AbstractNonCHBidirAlgo.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ public abstract class AbstractNonCHBidirAlgo extends AbstractBidirAlgo implement
4444
protected final Graph graph;
4545
protected final NodeAccess nodeAccess;
4646
protected final Weighting weighting;
47-
protected final FlagEncoder flagEncoder;
4847
protected EdgeExplorer edgeExplorer;
4948
protected EdgeFilter additionalEdgeFilter;
5049

@@ -53,7 +52,6 @@ public AbstractNonCHBidirAlgo(Graph graph, Weighting weighting, TraversalMode tM
5352
this.weighting = weighting;
5453
if (weighting.hasTurnCosts() && !tMode.isEdgeBased())
5554
throw new IllegalStateException("Weightings supporting turn costs cannot be used with node-based traversal mode");
56-
this.flagEncoder = weighting.getFlagEncoder();
5755
this.graph = graph;
5856
this.nodeAccess = graph.getNodeAccess();
5957
edgeExplorer = graph.createEdgeExplorer();

core/src/main/java/com/graphhopper/routing/AbstractRoutingAlgorithm.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
public abstract class AbstractRoutingAlgorithm implements RoutingAlgorithm {
3535
protected final Graph graph;
3636
protected final Weighting weighting;
37-
protected final FlagEncoder flagEncoder;
3837
protected final TraversalMode traversalMode;
3938
protected final NodeAccess nodeAccess;
4039
protected final EdgeExplorer edgeExplorer;
@@ -50,7 +49,6 @@ public AbstractRoutingAlgorithm(Graph graph, Weighting weighting, TraversalMode
5049
if (weighting.hasTurnCosts() && !traversalMode.isEdgeBased())
5150
throw new IllegalStateException("Weightings supporting turn costs cannot be used with node-based traversal mode");
5251
this.weighting = weighting;
53-
this.flagEncoder = weighting.getFlagEncoder();
5452
this.traversalMode = traversalMode;
5553
this.graph = graph;
5654
this.nodeAccess = graph.getNodeAccess();

core/src/main/java/com/graphhopper/routing/lm/LandmarkStorage.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ private double estimateMaxWeight(EdgeExplorer requireBothDirExplorer, List<IntAr
368368
int lmNodeId = tmpLandmarkNodeIds[lmIdx];
369369
explorer = new LandmarkExplorer(graph, this, weighting, traversalMode, true);
370370
explorer.setStartNode(lmNodeId);
371-
explorer.setFilter(blockedEdges, true, true);
371+
explorer.setFilter(blockedEdges, encoder.getAccessEnc(), true, true);
372372
explorer.runAlgo();
373373
maxWeight = Math.max(maxWeight, explorer.getLastEntry().weight);
374374
}
@@ -439,7 +439,7 @@ private boolean createLandmarksForSubnetwork(final int startNode, final byte[] s
439439
int lmNodeId = tmpLandmarkNodeIds[lmIdx];
440440
LandmarkExplorer explorer = new LandmarkExplorer(graph, this, weighting, traversalMode, true);
441441
explorer.setStartNode(lmNodeId);
442-
explorer.setFilter(blockedEdges, false, true);
442+
explorer.setFilter(blockedEdges, encoder.getAccessEnc(), false, true);
443443
explorer.runAlgo();
444444
explorer.initLandmarkWeights(lmIdx, lmNodeId, LM_ROW_LENGTH, FROM_OFFSET);
445445

@@ -451,7 +451,7 @@ private boolean createLandmarksForSubnetwork(final int startNode, final byte[] s
451451

452452
explorer = new LandmarkExplorer(graph, this, weighting, traversalMode, false);
453453
explorer.setStartNode(lmNodeId);
454-
explorer.setFilter(blockedEdges, true, false);
454+
explorer.setFilter(blockedEdges, encoder.getAccessEnc(), true, false);
455455
explorer.runAlgo();
456456
explorer.initLandmarkWeights(lmIdx, lmNodeId, LM_ROW_LENGTH, TO_OFFSET);
457457

@@ -740,15 +740,15 @@ private LandmarkExplorer findLandmarks(int[] landmarkNodeIdsToReturn, int startN
740740
Weighting initWeighting = lmSelectionWeighting;
741741
LandmarkExplorer explorer = new LandmarkExplorer(graph, this, initWeighting, traversalMode, true);
742742
explorer.setStartNode(startNode);
743-
explorer.setFilter(blockedEdges, true, true);
743+
explorer.setFilter(blockedEdges, encoder.getAccessEnc(), true, true);
744744
explorer.runAlgo();
745745

746746
if (explorer.getFromCount() >= minimumNodes) {
747747
// 1b) we have one landmark, now determine the other landmarks
748748
landmarkNodeIdsToReturn[0] = explorer.getLastEntry().adjNode;
749749
for (int lmIdx = 0; lmIdx < landmarkNodeIdsToReturn.length - 1; lmIdx++) {
750750
explorer = new LandmarkExplorer(graph, this, initWeighting, traversalMode, true);
751-
explorer.setFilter(blockedEdges, true, true);
751+
explorer.setFilter(blockedEdges, encoder.getAccessEnc(), true, true);
752752
// set all current landmarks as start so that the next getLastNode is hopefully a "far away" node
753753
for (int j = 0; j < lmIdx + 1; j++) {
754754
explorer.setStartNode(landmarkNodeIdsToReturn[j]);
@@ -789,8 +789,8 @@ public LandmarkExplorer(Graph g, LandmarkStorage lms, Weighting weighting, Trave
789789
setUpdateBestPath(false);
790790
}
791791

792-
public void setFilter(IntHashSet set, boolean bwd, boolean fwd) {
793-
edgeFilter = new BlockedEdgesFilter(flagEncoder.getAccessEnc(), bwd, fwd, set);
792+
public void setFilter(IntHashSet set, BooleanEncodedValue accessEnc, boolean bwd, boolean fwd) {
793+
edgeFilter = new BlockedEdgesFilter(accessEnc, bwd, fwd, set);
794794
}
795795

796796
public void setStartNode(int startNode) {

0 commit comments

Comments
 (0)