Skip to content

Commit 103c8a2

Browse files
authored
Fix serialization of SubscriptionExecutionResult for System.Text.Json (graphql-dotnet#2030)
1 parent 99d894a commit 103c8a2

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

src/GraphQL.ApiTests/GraphQL.SystemTextJson.approved.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ namespace GraphQL.SystemTextJson
1515
public class ExecutionResultJsonConverter : System.Text.Json.Serialization.JsonConverter<GraphQL.ExecutionResult>
1616
{
1717
public ExecutionResultJsonConverter(GraphQL.Execution.IErrorInfoProvider errorInfoProvider) { }
18+
public override bool CanConvert(System.Type typeToConvert) { }
1819
public override GraphQL.ExecutionResult Read(ref System.Text.Json.Utf8JsonReader reader, System.Type typeToConvert, System.Text.Json.JsonSerializerOptions options) { }
1920
public override void Write(System.Text.Json.Utf8JsonWriter writer, GraphQL.ExecutionResult value, System.Text.Json.JsonSerializerOptions options) { }
2021
}

src/GraphQL.NewtonsoftJson/ExecutionResultJsonConverter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,6 @@ private void WriteExtensions(ExecutionResult result, JsonWriter writer, JsonSeri
109109

110110
public override bool CanRead => false;
111111

112-
public override bool CanConvert(Type objectType) => objectType == typeof(ExecutionResult);
112+
public override bool CanConvert(Type objectType) => typeof(ExecutionResult).IsAssignableFrom(objectType);
113113
}
114114
}

src/GraphQL.SystemTextJson/ExecutionResultJsonConverter.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,5 +198,7 @@ private static void WriteExtensions(Utf8JsonWriter writer, ExecutionResult resul
198198

199199
public override ExecutionResult Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
200200
=> throw new NotImplementedException();
201+
202+
public override bool CanConvert(Type typeToConvert) => typeof(ExecutionResult).IsAssignableFrom(typeToConvert);
201203
}
202204
}

0 commit comments

Comments
 (0)