fix(gsoc'24): SubCircuit i/o nodes not consistent with localscope i/o nodes (CircuitVerse#355)

* fix(gsoc'24): SubCircuit i/o nodes not consistent with localscope i/o nodes

* Update subcircuit.js

---------

Co-authored-by: Arnabdaz <[email protected]>

Author: niladrix719

src/simulator/src/data/save.js

@@ -1,6 +1,6 @@
 import { scopeList } from '../circuit'
 import { resetup } from '../setup'
-import { update } from '../engine'
+import { update, updateSubcircuitSet } from '../engine'
 import { stripTags, showMessage } from '../utils'
 import { backUp } from './backupCircuit'
 import { simulationArea } from '../simulationArea'
@@ -122,6 +122,13 @@ export async function generateSaveData(name, setName = true) {
         }
 
         completed[id] = true
+
+        // This update is very important.
+        // if a scope's input/output changes and the user saves without going
+        // to circuits where this circuit is used as a subcircuit. It will
+        // break the code since the Subcircuit will have different number of
+        // in/out nodes compared to the localscope input/output objects.
+        updateSubcircuitSet(true);
         update(scopeList[id], true) // For any pending integrity checks on subcircuits
         data.scopes.push(backUp(scopeList[id]))
     }

src/simulator/src/node.js

@@ -47,6 +47,7 @@ export function replace(node, index) {
     node.parent = parent
     parent.nodeList.push(node)
     node.updateRotation()
+    node.scope.timeStamp = new Date().getTime()
     return node
 }
 function rotate(x1, y1, dir) {
@@ -186,6 +187,7 @@ export default class Node {
         this.hover = false
         this.wasClicked = false
         this.scope = this.parent.scope
+        this.scope.timeStamp = new Date().getTime()
         /**
          * @type {string}
          * value of this.prev is
@@ -289,6 +291,7 @@ export default class Node {
         for (var i = 0; i < this.connections.length; i++) {
             this.connections[i].connections = this.connections[i].connections.filter(x => x !== this)
         }
+        this.scope.timeStamp = new Date().getTime()
         this.connections = []
     }
 
@@ -341,6 +344,8 @@ export default class Node {
         this.connections.push(n)
         n.connections.push(this)
 
+        this.scope.timeStamp = new Date().getTime()
+
         updateCanvasSet(true)
         updateSimulationSet(true)
         scheduleUpdate()
@@ -355,7 +360,9 @@ export default class Node {
         this.connections.push(n)
         n.connections.push(this)
 
-        updateCanvasSet(true)
+        this.scope.timeStamp = new Date().getTime()
+
+        // updateCanvasSet(true)
         updateSimulationSet(true)
         scheduleUpdate()
     }
@@ -366,6 +373,8 @@ export default class Node {
     disconnectWireLess(n) {
         this.connections = this.connections.filter(x => x !== n)
         n.connections = n.connections.filter(x => x !== this)
+
+        this.scope.timeStamp = new Date().getTime()
     }
 
     /**
@@ -908,6 +917,9 @@ export default class Node {
             this.connections[i].connections = this.connections[i].connections.filter(x => x !== this)
             this.connections[i].checkDeleted()
         }
+
+        this.scope.timeStamp = new Date().getTime()
+
         wireToBeCheckedSet(1)
         forceResetNodesSet(true)
         scheduleUpdate()

src/simulator/src/subcircuit.js

@@ -258,7 +258,8 @@ export default class SubCircuit extends CircuitElement {
     }
 
     /**
-     * rebuilds the subcircuit if any change to localscope is made
+     * If the circuit referenced by localscope is changed, then the localscope
+     * needs to be updated. This function does that.
      */
     reBuildCircuit() {
         this.data = JSON.parse(scheduleBackup(scopeList[this.id]))
@@ -433,12 +434,9 @@ export default class SubCircuit extends CircuitElement {
             this.reBuildCircuit()
         }
 
-        // Should this be done here or only when this.reBuildCircuit() is called?
-        {
-            this.localScope.reset()
-            updateSimulationSet(true)
-            forceResetNodesSet(true)
-        }
+        this.localScope.reset()
+        updateSimulationSet(true)
+        forceResetNodesSet(true)
 
         this.makeConnections()
     }

src/simulator/src/wire.js

@@ -230,5 +230,7 @@ export default class Wire {
         this.scope.wires = this.scope.wires.filter(x => x !== this)
         this.node1.checkDeleted()
         this.node2.checkDeleted()
+
+        this.scope.timeStamp = new Date().getTime();
     }
 }