Fix stucks on large values in multi-row keys

Author: uglide

src/app/qmlutils.cpp

@@ -74,12 +74,17 @@ QVariant QmlUtils::binaryListToValue(const QVariantList &binaryList) {
   return value;
 }
 
-QVariant QmlUtils::printable(const QVariant &value, bool htmlEscaped) {
+QVariant QmlUtils::printable(const QVariant &value, bool htmlEscaped, int maxLength) {
   if (!value.canConvert(QVariant::ByteArray)) {
     return QVariant();
   }
+
   QByteArray val = value.toByteArray();
 
+  if (maxLength > 0 && val.size() > maxLength) {
+    val.truncate(maxLength);
+  }
+
   if (htmlEscaped) {
     return printableString(val).toHtmlEscaped();
   } else {

src/app/qmlutils.h

@@ -20,7 +20,7 @@ class QmlUtils : public QObject
     Q_INVOKABLE QString humanSize(long size);
     Q_INVOKABLE QVariant valueToBinary(const QVariant &value);
     Q_INVOKABLE QVariant binaryListToValue(const QVariantList& binaryList);
-    Q_INVOKABLE QVariant printable(const QVariant &value, bool htmlEscaped=false);
+    Q_INVOKABLE QVariant printable(const QVariant &value, bool htmlEscaped=false, int maxLength=-1);
     Q_INVOKABLE QVariant printableToValue(const QVariant &printable);
     Q_INVOKABLE QVariant toUtf(const QVariant &value);
     Q_INVOKABLE QString getPathFromUrl(const QUrl &url);

src/qml/value-editor/ValueTabs.qml

@@ -302,8 +302,7 @@ Repeater {
                             itemDelegate: Item {
                                 Text {
                                     anchors.fill: parent
-                                    color: styleData.textColor
-                                    elide: styleData.elideMode
+                                    color: styleData.textColor                                    
                                     text: {
 
                                         if (styleData.value === "" || !isMultiRow) {
@@ -314,9 +313,14 @@ Repeater {
                                             return parseFloat(Number(styleData.value).toFixed(20))
                                         }
 
+                                        if (qmlUtils.binaryStringLength(styleData.value) > 1000) {
+                                            return qmlUtils.printable(styleData.value, false, 1000) + "..."
+                                        }
+
                                         return qmlUtils.printable(styleData.value)
                                                             + (lineCount > 1 ? '...' : '')
                                     }
+                                    elide: Text.ElideRight
                                     wrapMode: Text.WrapAnywhere
                                     maximumLineCount: 1
                                 }
@@ -351,7 +355,7 @@ Repeater {
                                     }
                                 }
 
-                                onTotalRowCountChanged: {
+                                onTotalRowCountChanged: {                                    
                                     keyTab.keyModel.loadRows(table.currentStart, table.maxItemsOnPage)
                                 }
 
@@ -363,7 +367,7 @@ Repeater {
                                     keyTab.searchModel = keyTab.searchModelComponent.createObject(keyTab)
 
                                     if (isMultiRow) {
-                                        var columns = keyTab.keyModel.columnNames
+                                        var columns = keyTab.keyModel.columnNames                                        
 
                                         for (var index = 0; index < 3; index++)
                                         {