Skip to content

Commit fe17f6d

Browse files
VietND96VietND96
authored
feat: Adding port to nodes service (SeleniumHQ#1996)
* Bumping chart version Signed-off-by: Viet Nguyen Duc <[email protected]> * SeleniumHQ#1995 feat: Adding port to nodes service Signed-off-by: Viet Nguyen Duc <[email protected]> * Update chart CHANGELOG Signed-off-by: Viet Nguyen Duc <[email protected]> --------- Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent 87c0cf6 commit fe17f6d

File tree

7 files changed

+96
-5
lines changed

7 files changed

+96
-5
lines changed

‎charts/selenium-grid/CHANGELOG.md

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,23 @@
22

33
All notable changes to this helm chart will be documented in this file.
44

5+
## :heavy_check_mark: 0.24.0
6+
7+
### Added
8+
9+
- Update tag in docs and files [skip ci] :: Selenium CI Bot
10+
- Bumping chart version :: Diego Molina
11+
- Fix minor issues after PR #1881 and #1981 (#1983) :: Viet Nguyen Duc
12+
- Improve default value for videoRecorder in chart (#1984) :: Viet Nguyen Duc
13+
- Improve chart templates in the section videoRecorder (#1987) :: Viet Nguyen Duc
14+
- Update to Selenium 4.15.0 (#1990) :: Luis Correia
15+
- feat(autoscaling): Unified parameters to set scaled options for browser nodes (#1989) :: Viet Nguyen Duc
16+
- Add chart parameter ingress.paths to configure custom paths (#1994) :: Viet Nguyen Duc
17+
- feat: Adding port to nodes service (#1196) :: Viet Nguyen Duc
18+
19+
### Changed
20+
- Update image tag to 4.15.0-20231102
21+
522
## :heavy_check_mark: 0.23.0
623

724
### Added
@@ -11,7 +28,7 @@ All notable changes to this helm chart will be documented in this file.
1128
- Update Video/Dockerfile with based image ffmpeg:6.0-alpine (#1981) :: Viet Nguyen Duc
1229

1330
### Changed
14-
- Update image tag to 4.15.0-20231102
31+
- Update image tag to 4.14.1-20231025
1532

1633
## :heavy_check_mark: 0.22.0
1734

‎charts/selenium-grid/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ apiVersion: v2
22
name: selenium-grid
33
description: A Helm chart for creating a Selenium Grid Server in Kubernetes
44
type: application
5-
version: 0.23.0
6-
appVersion: 4.14.1-20231025
5+
version: 0.24.0
6+
appVersion: 4.15.0-20231102
77
icon: https://github.com/SeleniumHQ/docker-selenium/raw/trunk/logo.png
88
dependencies:
99
- repository: https://kedacore.github.io/charts

‎charts/selenium-grid/README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,8 @@ This table contains the configuration parameters of the chart and their default
147147
| `chromeNode.extraEnvFrom` | `nil` | Custom environment taken from `configMap` or `secret` variables for chrome nodes |
148148
| `chromeNode.service.enabled` | `true` | Create a service for node |
149149
| `chromeNode.service.type` | `ClusterIP` | Service type |
150+
| `chromeNode.service.loadBalancerIP` | `` | Set specific loadBalancerIP when serviceType is LoadBalancer |
151+
| `chromeNode.service.ports` | `[]` | Extra ports exposed in node service |
150152
| `chromeNode.service.annotations` | `{}` | Custom annotations for service |
151153
| `chromeNode.dshmVolumeSizeLimit` | `1Gi` | Size limit for DSH volume mounted in container (if not set, default is "1Gi") |
152154
| `chromeNode.startupProbe` | `{}` | Probe to check pod is started successfully |
@@ -184,6 +186,8 @@ This table contains the configuration parameters of the chart and their default
184186
| `firefoxNode.extraEnvFrom` | `nil` | Custom environment variables taken from `configMap` or `secret` for firefox nodes |
185187
| `firefoxNode.service.enabled` | `true` | Create a service for node |
186188
| `firefoxNode.service.type` | `ClusterIP` | Service type |
189+
| `firefoxNode.service.loadBalancerIP` | `` | Set specific loadBalancerIP when serviceType is LoadBalancer |
190+
| `firefoxNode.service.ports` | `[]` | Extra ports exposed in node service |
187191
| `firefoxNode.service.annotations` | `{}` | Custom annotations for service |
188192
| `firefoxNode.dshmVolumeSizeLimit` | `1Gi` | Size limit for DSH volume mounted in container (if not set, default is "1Gi") |
189193
| `firefoxNode.startupProbe` | `{}` | Probe to check pod is started successfully |
@@ -221,6 +225,8 @@ This table contains the configuration parameters of the chart and their default
221225
| `edgeNode.extraEnvFrom` | `nil` | Custom environment taken from `configMap` or `secret` variables for firefox nodes |
222226
| `edgeNode.service.enabled` | `true` | Create a service for node |
223227
| `edgeNode.service.type` | `ClusterIP` | Service type |
228+
| `edgeNode.service.loadBalancerIP` | `` | Set specific loadBalancerIP when serviceType is LoadBalancer |
229+
| `edgeNode.service.ports` | `[]` | Extra ports exposed in node service |
224230
| `edgeNode.service.annotations` | `{}` | Custom annotations for service |
225231
| `edgeNode.dshmVolumeSizeLimit` | `1Gi` | Size limit for DSH volume mounted in container (if not set, default is "1Gi") |
226232
| `edgeNode.startupProbe` | `{}` | Probe to check pod is started successfully |

‎charts/selenium-grid/templates/chrome-node-service.yaml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,25 @@ spec:
1616
selector:
1717
app: selenium-chrome-node
1818
app.kubernetes.io/instance: {{ .Release.Name }}
19+
{{- if and (eq .Values.chromeNode.service.type "LoadBalancer") (.Values.chromeNode.service.loadBalancerIP) }}
20+
loadBalancerIP: {{ .Values.chromeNode.service.loadBalancerIP }}
21+
{{- end }}
1922
ports:
2023
- name: tcp-chrome
2124
protocol: TCP
2225
port: {{ .Values.chromeNode.seleniumServicePort }}
2326
targetPort: {{ .Values.chromeNode.seleniumPort }}
27+
{{- with .Values.chromeNode.service.ports }}
28+
{{- range . }}
29+
- name: {{ .name }}
30+
port: {{ .port }}
31+
targetPort: {{ .targetPort }}
32+
{{- if .protocol }}
33+
protocol: {{ .protocol }}
34+
{{- end }}
35+
{{- if and (eq $.Values.chromeNode.service.type "NodePort") .nodePort }}
36+
nodePort: {{ .nodePort }}
37+
{{- end }}
38+
{{- end }}
39+
{{- end }}
2440
{{- end }}

‎charts/selenium-grid/templates/edge-node-service.yaml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,25 @@ spec:
1616
selector:
1717
app: selenium-edge-node
1818
app.kubernetes.io/instance: {{ .Release.Name }}
19+
{{- if and (eq .Values.edgeNode.service.type "LoadBalancer") (.Values.edgeNode.service.loadBalancerIP) }}
20+
loadBalancerIP: {{ .Values.edgeNode.service.loadBalancerIP }}
21+
{{- end }}
1922
ports:
2023
- name: tcp-edge
2124
protocol: TCP
2225
port: {{ .Values.edgeNode.seleniumServicePort }}
2326
targetPort: {{ .Values.edgeNode.seleniumPort }}
27+
{{- with .Values.edgeNode.service.ports }}
28+
{{- range . }}
29+
- name: {{ .name }}
30+
port: {{ .port }}
31+
targetPort: {{ .targetPort }}
32+
{{- if .protocol }}
33+
protocol: {{ .protocol }}
34+
{{- end }}
35+
{{- if and (eq $.Values.edgeNode.service.type "NodePort") .nodePort }}
36+
nodePort: {{ .nodePort }}
37+
{{- end }}
38+
{{- end }}
39+
{{- end }}
2440
{{- end }}

‎charts/selenium-grid/templates/firefox-node-service.yaml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,25 @@ spec:
1616
selector:
1717
app: selenium-firefox-node
1818
app.kubernetes.io/instance: {{ .Release.Name }}
19+
{{- if and (eq .Values.firefoxNode.service.type "LoadBalancer") (.Values.firefoxNode.service.loadBalancerIP) }}
20+
loadBalancerIP: {{ .Values.firefoxNode.service.loadBalancerIP }}
21+
{{- end }}
1922
ports:
2023
- name: tcp-firefox
2124
protocol: TCP
2225
port: {{ .Values.firefoxNode.seleniumServicePort }}
2326
targetPort: {{ .Values.firefoxNode.seleniumPort }}
27+
{{- with .Values.firefoxNode.service.ports }}
28+
{{- range . }}
29+
- name: {{ .name }}
30+
port: {{ .port }}
31+
targetPort: {{ .targetPort }}
32+
{{- if .protocol }}
33+
protocol: {{ .protocol }}
34+
{{- end }}
35+
{{- if and (eq $.Values.firefoxNode.service.type "NodePort") .nodePort }}
36+
nodePort: {{ .nodePort }}
37+
{{- end }}
38+
{{- end }}
39+
{{- end }}
2440
{{- end }}

‎charts/selenium-grid/values.yaml

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -464,6 +464,13 @@ chromeNode:
464464
enabled: true
465465
# Service type
466466
type: ClusterIP
467+
# Set specific loadBalancerIP when serviceType is LoadBalancer (see https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer)
468+
loadBalancerIP: ""
469+
# Extra ports exposed in node service
470+
ports:
471+
# - name: node-port
472+
# port: 5555
473+
# targetPort: 5555
467474
# Custom annotations for service
468475
annotations: {}
469476
# Size limit for DSH volume mounted in container (if not set, default is "1Gi")
@@ -589,6 +596,13 @@ firefoxNode:
589596
enabled: true
590597
# Service type
591598
type: ClusterIP
599+
# Set specific loadBalancerIP when serviceType is LoadBalancer (see https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer)
600+
loadBalancerIP: ""
601+
# Extra ports exposed in node service
602+
ports:
603+
# - name: node-port
604+
# port: 5555
605+
# targetPort: 5555
592606
# Custom annotations for service
593607
annotations: {}
594608
# Size limit for DSH volume mounted in container (if not set, default is "1Gi")
@@ -710,9 +724,15 @@ edgeNode:
710724
enabled: true
711725
# Service type
712726
type: ClusterIP
727+
# Set specific loadBalancerIP when serviceType is LoadBalancer (see https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer)
728+
loadBalancerIP: ""
729+
# Extra ports exposed in node service
730+
ports:
731+
# - name: node-port
732+
# port: 5555
733+
# targetPort: 5555
713734
# Custom annotations for service
714-
annotations:
715-
hello: world
735+
annotations: {}
716736
# Size limit for DSH volume mounted in container (if not set, default is "1Gi")
717737
dshmVolumeSizeLimit: 1Gi
718738
# Priority class name for edge-node pods

0 commit comments

Comments
 (0)