fix other linter stuff

Author: felixdivo

.pylintrc-wip

@@ -75,46 +75,13 @@ disable=blacklisted-name,
         wrong-import-order,
         ungrouped-imports,
         wrong-import-position,
-        too-many-star-expressions,
-        invalid-star-assignment-target,
         method-hidden,
-        access-member-before-definition,
-        no-method-argument,
-        no-self-argument,
-        invalid-slots-object,
-        assigning-non-slot,
-        duplicate-bases,
-        non-iterator-returned,
-        unexpected-special-method-signature,
-        invalid-length-returned,
-        import-error,
-        relative-beyond-top-level,
-        used-before-assignment,
-        undefined-variable,
-        undefined-all-variable,
-        invalid-all-object,
-        no-name-in-module,
-        unpacking-non-sequence,
-        bad-exception-context,
         misplaced-bare-raise,
-        raising-non-exception,
-        notimplemented-raised,
-        catching-non-exception,
-        no-value-for-parameter,
         too-many-function-args,
-        unexpected-keyword-arg,
-        redundant-keyword-arg,
         print-statement,
-        parameter-unpacking,
-        unpacking-in-except,
         import-star-module-level,
-        yield-inside-async-function,
         locally-disabled,
-        file-ignored,
         no-self-use,
-        useless-object-inheritance,
-        cyclic-import,
-        duplicate-code,
         too-many-ancestors,
         too-many-instance-attributes,
         too-few-public-methods,
@@ -125,22 +92,7 @@ disable=blacklisted-name,
         too-many-locals,
         too-many-statements,
         too-many-nested-blocks,
-        inconsistent-return-statements,
         no-else-raise,
-        dangerous-default-value,
-        pointless-statement,
-        pointless-string-statement,
-        expression-not-assigned,
-        unnecessary-pass,
-        unnecessary-lambda,
-        duplicate-key,
-        assign-to-new-keyword,
-        useless-else-on-loop,
-        exec-used,
-        eval-used,
-        confusing-with-statement,
-        using-constant-test,
-        comparison-with-callable,
         lost-exception,
         assert-on-tuple,
         attribute-defined-outside-init,
@@ -154,9 +106,7 @@ disable=blacklisted-name,
         non-parent-init-called,
         bad-indentation,
         wildcard-import,
-        misplaced-future,
         fixme,
-        invalid-encoded-data,
         unused-import,
         unused-variable,
         unused-argument,
@@ -172,19 +122,18 @@ disable=blacklisted-name,
         invalid-format-index,
         no-absolute-import,
         dict-iter-method,
-        indexing-exception,
-        raising-string,
         oct-method,
         hex-method,
         exception-message-attribute,
-        invalid-str-codec,
-        sys-max-int,
-        next-method-defined,
         redefined-builtin,
         no-else-return,
         redefined-argument-from-local,
         abstract-class-instantiated,
-        multiple-statements
+        multiple-statements,
+        cyclic-import,
+        useless-else-on-loop,
+        duplicate-code,
+        inconsistent-return-statements
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option

can/__init__.py

@@ -17,7 +17,6 @@ class CanError(IOError):
     """Indicates an error with the CAN network.
 
     """
-    pass
 
 
 from .listener import Listener, BufferedReader, RedirectReader, AsyncBufferedReader

can/bus.py

@@ -313,7 +313,6 @@ def _apply_filters(self, filters):
         :param Iterator[dict] filters:
             See :meth:`~can.BusABC.set_filters` for details.
         """
-        pass
 
     def _matches_filters(self, msg):
         """Checks whether the given message matches at least one of the
@@ -354,14 +353,12 @@ def _matches_filters(self, msg):
     def flush_tx_buffer(self):
         """Discard every message that may be queued in the output buffer(s).
         """
-        pass
 
     def shutdown(self):
         """
         Called to carry out any interface specific cleanup required
         in shutting down a bus.
         """
-        pass
 
     def __enter__(self):
         return self

can/interfaces/ixxat/exceptions.py

@@ -13,12 +13,10 @@
 
 class VCITimeout(CanError):
     """ Wraps the VCI_E_TIMEOUT error """
-    pass
 
 
 class VCIError(CanError):
     """ Try to display errors that occur within the wrapped C library nicely. """
-    pass
 
 
 class VCIRxQueueEmptyError(VCIError):

can/interfaces/kvaser/canlib.py

@@ -41,7 +41,8 @@ def _unimplemented_function(*args):
     raise NotImplementedError('This function is not implemented in canlib')
 
 
-def __get_canlib_function(func_name, argtypes=[], restype=None, errcheck=None):
+def __get_canlib_function(func_name, argtypes=None, restype=None, errcheck=None):
+    argtypes = [] if argtypes is None else argtypes
     #log.debug('Wrapping function "%s"' % func_name)
     try:
         # e.g. canlib.canBusOn

can/interfaces/pcan/pcan.py

@@ -426,4 +426,3 @@ class PcanError(CanError):
     """
     A generic error on a PCAN bus.
     """
-    pass

can/interfaces/serial/serial_can.py

@@ -121,7 +121,7 @@ def _recv_internal(self, timeout):
                 message are the default values.
 
         :rtype:
-            can.Message, bool
+            Tuple[can.Message, Bool]
         """
         try:
             # ser.read can return an empty string

can/interfaces/systec/structures.py

@@ -35,7 +35,8 @@ class CanMsg(Structure):
         ("m_dwTime", DWORD,)  # Receive time stamp in ms (for transmit messages no meaning)
     ]
 
-    def __init__(self, id=0, frame_format=MsgFrameFormat.MSG_FF_STD, data=[]):
+    def __init__(self, id=0, frame_format=MsgFrameFormat.MSG_FF_STD, data=None):
+        data = [] if data is None else data
         super().__init__(id, frame_format, len(data), (BYTE * 8)(*data), 0)
 
     def __eq__(self, other):

can/interfaces/systec/ucan.py

@@ -291,7 +291,7 @@ def check_result(result, func, arguments):
         log.warning("Cannot load SYSTEC ucan library: %s.", ex)
 
 
-class UcanServer(object):
+class UcanServer:
     """
     UcanServer is a Python wrapper class for using the usbcan32.dll / usbcan64.dll.
     """
@@ -987,7 +987,6 @@ def init_hw_event(self):
 
         .. note:: To be overridden by subclassing.
         """
-        pass
 
     def init_can_event(self, channel):
         """
@@ -997,7 +996,6 @@ def init_can_event(self, channel):
 
         .. note:: To be overridden by subclassing.
         """
-        pass
 
     def can_msg_received_event(self, channel):
         """
@@ -1009,7 +1007,6 @@ def can_msg_received_event(self, channel):
 
         .. note:: To be overridden by subclassing.
         """
-        pass
 
     def status_event(self, channel):
         """
@@ -1021,7 +1018,6 @@ def status_event(self, channel):
 
         .. note:: To be overridden by subclassing.
         """
-        pass
 
     def deinit_can_event(self, channel):
         """
@@ -1031,31 +1027,27 @@ def deinit_can_event(self, channel):
 
         .. note:: To be overridden by subclassing.
         """
-        pass
 
     def deinit_hw_event(self):
         """
         Event occurs when an USB-CANmodul has been deinitialized (see method :meth:`shutdown`).
 
         .. note:: To be overridden by subclassing.
         """
-        pass
 
     def connect_event(self):
         """
         Event occurs when a new USB-CANmodul has been connected to the host.
 
         .. note:: To be overridden by subclassing.
         """
-        pass
 
     def disconnect_event(self):
         """
         Event occurs when an USB-CANmodul has been disconnected from the host.
 
         .. note:: To be overridden by subclassing.
         """
-        pass
 
     def fatal_disconnect_event(self, device_number):
         """
@@ -1067,7 +1059,6 @@ def fatal_disconnect_event(self, device_number):
 
         .. note:: To be overridden by subclassing.
         """
-        pass
 
 
 UcanServer._enum_callback_ref = EnumCallback(UcanServer._enum_callback)

can/io/blf.py

@@ -28,7 +28,7 @@
 
 class BLFParseError(Exception):
     """BLF file could not be parsed correctly."""
-    pass
+
 
 LOG = logging.getLogger(__name__)
 

can/listener.py

@@ -39,7 +39,6 @@ def on_message_received(self, msg):
         :param can.Message msg: the delivered message
 
         """
-        pass
 
     def __call__(self, msg):
         return self.on_message_received(msg)

can/thread_safe_bus.py

@@ -18,7 +18,7 @@
     from contextlib import nullcontext
 
 except ImportError:
-    class nullcontext(object):
+    class nullcontext:
         """A context manager that does nothing at all.
         A fallback for Python 3.7's :class:`contextlib.nullcontext` manager.
         """