Skip to content

Commit 4889a8f

Browse files
authored
Merge pull request #2212 from makarid/develop
[bitbay] I have corrected a bug in transactions method of BitbayTradeService
2 parents 9838505 + c12d125 commit 4889a8f

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

xchange-bitbay/src/main/java/org/knowm/xchange/bitbay/service/BitbayTradeService.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,7 @@
1919
import org.knowm.xchange.dto.trade.UserTrades;
2020
import org.knowm.xchange.exceptions.NotAvailableFromExchangeException;
2121
import org.knowm.xchange.service.trade.TradeService;
22-
import org.knowm.xchange.service.trade.params.CancelOrderByIdParams;
23-
import org.knowm.xchange.service.trade.params.CancelOrderParams;
24-
import org.knowm.xchange.service.trade.params.TradeHistoryParamCurrencyPair;
25-
import org.knowm.xchange.service.trade.params.TradeHistoryParams;
26-
import org.knowm.xchange.service.trade.params.TradeHistoryParamsZero;
22+
import org.knowm.xchange.service.trade.params.*;
2723
import org.knowm.xchange.service.trade.params.orders.OpenOrdersParams;
2824

2925
/**
@@ -93,7 +89,7 @@ public UserTrades getTradeHistory(TradeHistoryParams params) throws IOException
9389

9490
@Override
9591
public TradeHistoryParams createTradeHistoryParams() {
96-
return new TradeHistoryParamsZero();
92+
return new TradeHistoryParamsAll();
9793
}
9894

9995
@Override

xchange-bitbay/src/main/java/org/knowm/xchange/bitbay/service/BitbayTradeServiceRaw.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public List<BitbayOrder> getBitbayOpenOrders() throws IOException, ExchangeExcep
2727
}
2828

2929
public List<Map> getBitbayTransactions(CurrencyPair currencyPair) throws IOException, ExchangeException {
30-
return bitbayAuthenticated.transactions(apiKey, sign, exchange.getNonceFactory(), currencyPair == null ? null : currencyPair.toString());
30+
return bitbayAuthenticated.transactions(apiKey, sign, exchange.getNonceFactory(), currencyPair == null ? null : currencyPair.base.toString()+"-"+currencyPair.counter.toString());
3131
}
3232

3333
public BitbayTradeResponse placeBitbayOrder(LimitOrder order) throws IOException {

0 commit comments

Comments
 (0)