Skip to content

Commit e42fd96

Browse files
timmoltertimmolter
authored
Merge pull request #2186 from bryantharris/abucoins_setting_fees
[abucoins] Updating metadata on currency pairs and currencies from abucoins
2 parents e63599c + 057a456 commit e42fd96

File tree

3 files changed

+239
-34
lines changed

3 files changed

+239
-34
lines changed

‎xchange-abucoins/src/main/resources/abucoins.json

Lines changed: 191 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,84 +1,241 @@
11
{
22
"currency_pairs": {
3-
"BTC/USD": {
3+
"BTC/PLN": {
44
"price_scale": 2,
5-
"trading_fee": 0.002,
5+
"trading_fee": 0.0025,
66
"min_amount": 0.010000000
77
},
8-
"BTC/EUR": {
8+
"ETH/PLN": {
99
"price_scale": 2,
10-
"trading_fee": 0.001,
10+
"trading_fee": 0.0025,
1111
"min_amount": 0.010000000
1212
},
13-
"BTC/GBP": {
13+
"BTC/EUR": {
1414
"price_scale": 2,
15-
"trading_fee": 0.01,
15+
"trading_fee": 0.0025,
1616
"min_amount": 0.010000000
1717
},
18-
"ETH/GBP": {
19-
"price_scale": 4,
20-
"trading_fee": 0.001,
18+
"BTC/USD": {
19+
"price_scale": 2,
20+
"trading_fee": 0.0025,
2121
"min_amount": 0.100000000
2222
},
23-
"ETH/BTC": {
24-
"price_scale": 8,
25-
"trading_fee": 0.0000,
23+
"BCH/PLN": {
24+
"price_scale": 2,
25+
"trading_fee": 0.0025,
2626
"min_amount": 0.500000000
2727
},
28-
"ETH/USD": {
29-
"price_scale": 4,
30-
"trading_fee": 0.002,
28+
"BCH/BTC": {
29+
"price_scale": 8,
30+
"trading_fee": 0.001,
3131
"min_amount": 0.500000000
3232
},
33-
"ETH/EUR": {
34-
"price_scale": 4,
33+
"ETH/BTC": {
34+
"price_scale": 8,
3535
"trading_fee": 0.001,
3636
"min_amount": 0.500000000
3737
},
38-
"BCH/BTC": {
38+
"DASH/BTC": {
3939
"price_scale": 8,
40-
"trading_fee": 0.0000,
40+
"trading_fee": 0.001,
4141
"min_amount": 0.100000000
4242
},
43-
"BCH/USD": {
44-
"price_scale": 4,
45-
"trading_fee": 0.002,
43+
"ZEC/BTC": {
44+
"price_scale": 8,
45+
"trading_fee": 0.001,
4646
"min_amount": 0.0100000000
4747
},
48-
"BCH/EUR": {
49-
"price_scale": 4,
48+
"XMR/BTC": {
49+
"price_scale": 8,
5050
"trading_fee": 0.001,
5151
"min_amount": 0.0100000000
5252
},
53-
"BCH/GBP": {
54-
"price_scale": 4,
55-
"trading_fee": 0.002,
53+
"BTG/BTC": {
54+
"price_scale": 8,
55+
"trading_fee": 0.001,
56+
"min_amount": 0.010000000
57+
},
58+
"LTC/BTC": {
59+
"price_scale": 8,
60+
"trading_fee": 0.001,
61+
"min_amount": 0.010000000
62+
},
63+
"REP/BTC": {
64+
"price_scale": 8,
65+
"trading_fee": 0.001,
66+
"min_amount": 0.010000000
67+
},
68+
"ETC/BTC": {
69+
"price_scale": 8,
70+
"trading_fee": 0.001,
71+
"min_amount": 0.010000000
72+
},
73+
"STRAT/BTC": {
74+
"price_scale": 8,
75+
"trading_fee": 0.001,
76+
"min_amount": 0.010000000
77+
},
78+
"XRP/BTC": {
79+
"price_scale": 8,
80+
"trading_fee": 0.001,
81+
"min_amount": 0.010000000
82+
},
83+
"XEM/BTC": {
84+
"price_scale": 8,
85+
"trading_fee": 0.001,
86+
"min_amount": 0.010000000
87+
},
88+
"GNT/BTC": {
89+
"price_scale": 8,
90+
"trading_fee": 0.001,
91+
"min_amount": 0.010000000
92+
},
93+
"SC/BTC": {
94+
"price_scale": 8,
95+
"trading_fee": 0.001,
96+
"min_amount": 0.010000000
97+
},
98+
"ETH/EUR": {
99+
"price_scale": 2,
100+
"trading_fee": 0.0025,
101+
"min_amount": 0.010000000
102+
},
103+
"LSK/PLN": {
104+
"price_scale": 2,
105+
"trading_fee": 0.0025,
106+
"min_amount": 0.010000000
107+
},
108+
"LSK/BTC": {
109+
"price_scale": 8,
110+
"trading_fee": 0.001,
111+
"min_amount": 0.010000000
112+
},
113+
"BCH/EUR": {
114+
"price_scale": 2,
115+
"trading_fee": 0.0025,
116+
"min_amount": 0.010000000
117+
},
118+
"ETH/USD": {
119+
"price_scale": 2,
120+
"trading_fee": 0.0025,
121+
"min_amount": 0.010000000
122+
},
123+
"BTG/PLN": {
124+
"price_scale": 2,
125+
"trading_fee": 0.0025,
126+
"min_amount": 0.010000000
127+
},
128+
"BCH/USD": {
129+
"price_scale": 2,
130+
"trading_fee": 0.0025,
131+
"min_amount": 0.010000000
132+
},
133+
"LSK/USD": {
134+
"price_scale": 2,
135+
"trading_fee": 0.0025,
136+
"min_amount": 0.010000000
137+
},
138+
"LSK/EUR": {
139+
"price_scale": 2,
140+
"trading_fee": 0.0025,
141+
"min_amount": 0.010000000
142+
},
143+
"BTG/EUR": {
144+
"price_scale": 2,
145+
"trading_fee": 0.0025,
146+
"min_amount": 0.010000000
147+
},
148+
"HSR/BTC": {
149+
"price_scale": 8,
150+
"trading_fee": 0.001,
151+
"min_amount": 0.010000000
152+
},
153+
"BTG/USD": {
154+
"price_scale": 2,
155+
"trading_fee": 0.0025,
56156
"min_amount": 0.010000000
57157
}
58158
},
59159
"currencies": {
60160
"BCH": {
61161
"scale": 8,
62-
"withdrawal_fee": 0.001
162+
"withdrawal_fee": 0.0001
63163
},
64164
"BTC": {
65165
"scale": 8,
66166
"withdrawal_fee": 0.001
67167
},
68-
"ETH": {
168+
"BTG": {
169+
"scale": 8,
170+
"withdrawal_fee": 0.0005
171+
},
172+
"DASH": {
69173
"scale": 8,
70174
"withdrawal_fee": 0.01
71175
},
72-
"GBP": {
73-
"scale": 2,
74-
"withdrawal_fee": 3.80
176+
"ETC": {
177+
"scale": 8,
178+
"withdrawal_fee": 0.01
179+
},
180+
"ETH": {
181+
"scale": 8,
182+
"withdrawal_fee": 0.005
75183
},
76184
"EUR": {
77185
"scale": 2,
78-
"withdrawal_fee": 3.80
186+
"withdrawal_fee": 1
187+
},
188+
"GNT": {
189+
"scale": 8,
190+
"withdrawal_fee": 0.01
191+
},
192+
"HSR": {
193+
"scale": 8,
194+
"withdrawal_fee": 0.5
195+
},
196+
"LSK": {
197+
"scale": 8,
198+
"withdrawal_fee": 0.2
199+
},
200+
"LTC": {
201+
"scale": 8,
202+
"withdrawal_fee": 0.001
203+
},
204+
"PLN": {
205+
"scale": 2,
206+
"withdrawal_fee": 0
207+
},
208+
"REP": {
209+
"scale": 8,
210+
"withdrawal_fee": 0.01
211+
},
212+
"SC": {
213+
"scale": 8,
214+
"withdrawal_fee": 10
215+
},
216+
"STRAT": {
217+
"scale": 8,
218+
"withdrawal_fee": 0.01
79219
},
80220
"USD": {
81-
"scale": 2
221+
"scale": 2,
222+
"withdrawal_fee": 50
223+
},
224+
"XEM": {
225+
"scale": 8,
226+
"withdrawal_fee": 2
227+
},
228+
"XMR": {
229+
"scale": 8,
230+
"withdrawal_fee": 0.02
231+
},
232+
"XRP": {
233+
"scale": 8,
234+
"withdrawal_fee": 0.5
235+
},
236+
"ZEC": {
237+
"scale": 8,
238+
"withdrawal_fee": 0.001
82239
}
83240
},
84241
"private_rate_limits": [

‎xchange-abucoins/src/test/java/org/knowm/xchange/abucoins/AbucoinsExchangeMetaDataTest.java

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
package org.knowm.xchange.abucoins;
2+
3+
import static org.junit.Assert.*;
4+
5+
import java.util.Map;
6+
7+
import org.junit.Before;
8+
import org.junit.Test;
9+
import org.knowm.xchange.ExchangeFactory;
10+
import org.knowm.xchange.currency.Currency;
11+
import org.knowm.xchange.currency.CurrencyPair;
12+
import org.knowm.xchange.dto.meta.CurrencyMetaData;
13+
import org.knowm.xchange.dto.meta.CurrencyPairMetaData;
14+
import org.knowm.xchange.dto.meta.ExchangeMetaData;
15+
16+
public class AbucoinsExchangeMetaDataTest {
17+
AbucoinsExchange exchange;
18+
19+
@Before
20+
public void setUp() throws Exception {
21+
exchange = (AbucoinsExchange) ExchangeFactory.INSTANCE.createExchange(AbucoinsExchange.class);
22+
}
23+
24+
@Test
25+
public void testCurrencyPairs() {
26+
ExchangeMetaData metaData = exchange.getExchangeMetaData();
27+
assertNotNull("meta data is null", metaData);
28+
29+
Map<CurrencyPair,CurrencyPairMetaData> currencyPairs = metaData.getCurrencyPairs();
30+
31+
assertNotNull("currencyPairs meta data is null", currencyPairs);
32+
assertEquals("Wrong number of currency pairs", 31, currencyPairs.size());
33+
}
34+
35+
@Test
36+
public void testCurrencies() {
37+
ExchangeMetaData metaData = exchange.getExchangeMetaData();
38+
assertNotNull("meta data is null", metaData);
39+
40+
Map<Currency,CurrencyMetaData> currencies = metaData.getCurrencies();
41+
42+
assertNotNull("currencies meta data is null", currencies);
43+
assertEquals("Wrong number of currencies", 20, currencies.size());
44+
}
45+
}

‎xchange-core/src/main/java/org/knowm/xchange/currency/Currency.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ public class Currency implements Comparable<Currency>, Serializable {
105105
public static final Currency GMD = createCurrency("GMD", "Gambian Dalasi", null);
106106
public static final Currency GNF = createCurrency("GNF", "Guinean Franc", null);
107107
public static final Currency GNO = createCurrency("GNO", "Gnosis", null);
108+
public static final Currency GNT = createCurrency("GNT", "Golem", null);
108109
public static final Currency GTQ = createCurrency("GTQ", "Guatemalan Quetzal", null);
109110
public static final Currency GYD = createCurrency("GYD", "Guyanaese Dollar", null);
110111
public static final Currency HKD = createCurrency("HKD", "Hong Kong Dollar", null);
@@ -210,6 +211,7 @@ public class Currency implements Comparable<Currency>, Serializable {
210211
public static final Currency START = createCurrency("START", "startcoin", null);
211212
public static final Currency STD = createCurrency("STD", "São Tomé and Príncipe Dobra", null);
212213
public static final Currency STR = createCurrency("STR", "Stellar", null);
214+
public static final Currency STRAT = createCurrency("STRAT", "Stratis", null);
213215
public static final Currency SVC = createCurrency("SVC", "Salvadoran Colón", null);
214216
public static final Currency SYP = createCurrency("SYP", "Syrian Pound", null);
215217
public static final Currency SZL = createCurrency("SZL", "Swazi Lilangeni", null);
@@ -244,6 +246,7 @@ public class Currency implements Comparable<Currency>, Serializable {
244246
public static final Currency XAUR = createCurrency("XAUR", "Xaurum", null);
245247
public static final Currency XCD = createCurrency("XCD", "East Caribbean Dollar", null);
246248
public static final Currency XDR = createCurrency("XDR", "Special Drawing Rights", null);
249+
public static final Currency XEM = createCurrency("XEM", "NEM", null);
247250
public static final Currency XLM = createCurrency("XLM", "Stellar Lumen", null);
248251
public static final Currency XMR = createCurrency("XMR", "Monero", null);
249252
public static final Currency XRB = createCurrency("XRB", "Rai Blocks", null);

0 commit comments

Comments
 (0)