[Feature] Encodable and Decodable for Signature

[greged93]

Component

primitives

Describe the feature you would like

The alloy_rlp::Encodable and alloy_rlp::Decodable implementations were removed in this commit. I propose to reintroduce the implementations behind the rlp flag as was done before.

Additional context

No response

[nadtech-hub]

I can do that if maintainers allow it

[klkvr]

those were removed to avoid footguns as encoding for signatures may differ depending on context (e.g legacy and non-legacy transactions are using different rlp)

[mattsse]

yeah Signature encoding depends on the transaction type, there is Signature::decode_rlp_vrs

e.g. let signature = Signature::decode_rlp_vrs(buf, bool::decode)?; for non legacy transactions where signature has a parity bool

[greged93]

makes sense, thanks for the answer!

[mattsse]

leaving this as reference:

signature.write_rlp_vrs(out, signature.v());

https://github.com/alloy-rs/alloy/blob/20154fc9c5e34c7e88dddfda51fdd84ee97b6084/crates/consensus/src/transaction/rlp.rs#L56-L56

https://github.com/alloy-rs/alloy/blob/20154fc9c5e34c7e88dddfda51fdd84ee97b6084/crates/consensus/src/transaction/rlp.rs#L158-L158