Skip to content

[Feature] Add decode_log_validate and decode_raw_log_validate to SolEventInterface #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gsnoff opened this issue May 29, 2025 · 1 comment
Open

[Feature] Add decode_log_validate and decode_raw_log_validate to SolEventInterface #955

gsnoff opened this issue May 29, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@gsnoff
Copy link

gsnoff commented May 29, 2025

Component

sol-types

Describe the feature you would like

The validate bool arg was removed in #863.

#928 so far only added decode_raw_log_validate method for individual SolEvent log types. A decode_log_validate method is still missing.

The trait SolEventInterface that is used for enums representing all defined events which are generated by sol! macro currently has neither decode_log_validate nor decode_raw_log_validate methods. I think we should have those methods as well.

Additional context

No response
@gsnoff gsnoff added the enhancement New feature or request label May 29, 2025
@github-project-automation github-project-automation bot moved this to Todo in Alloy May 29, 2025
@nadtech-hub
Copy link

I can make it if approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Alloy
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsnoff @nadtech-hub