Merge pull request libgit2#443 from walkenzoy/master

carlosmn · web-flow · commit 14280de4da0f · 2018-05-31T07:26:17.000+02:00
git2go: fix reference iterator leak
diff --git a/reference.go b/reference.go
@@ -456,10 +456,12 @@ func (v *ReferenceIterator) Next() (*Reference, error) {
 }
 
 func newReferenceIteratorFromC(ptr *C.git_reference_iterator, r *Repository) *ReferenceIterator {
-	return &ReferenceIterator{
+	iter := &ReferenceIterator{
 		ptr:  ptr,
 		repo: r,
 	}
+	runtime.SetFinalizer(iter, (*ReferenceIterator).Free)
+	return iter
 }
 
 // Free the reference iterator

Original file line number	Diff line number	Diff line change
`@@ -456,10 +456,12 @@ func (v ReferenceIterator) Next() (Reference, error) {`
`456`	`456`	`}`
`457`	`457`
`458`	`458`	`func newReferenceIteratorFromC(ptr C.git_reference_iterator, r Repository) *ReferenceIterator {`
`459`		`- return &ReferenceIterator{`
	`459`	`+ iter := &ReferenceIterator{`
`460`	`460`	`ptr: ptr,`
`461`	`461`	`repo: r,`
`462`	`462`	`}`
	`463`	`+ runtime.SetFinalizer(iter, (*ReferenceIterator).Free)`
	`464`	`+ return iter`
`463`	`465`	`}`
`464`	`466`
`465`	`467`	`// Free the reference iterator`