Fixed creation of aws_vpc_endpoint_route_table_association when intra_subnets are not set (fixes 137)

antonbabenko · antonbabenko · commit 0a56c64813de · 2018-06-05T18:59:20.000+02:00
diff --git a/main.tf b/main.tf
@@ -286,7 +286,7 @@ resource "aws_vpc_endpoint_route_table_association" "private_s3" {
 }
 
 resource "aws_vpc_endpoint_route_table_association" "intra_s3" {
-  count = "${var.create_vpc && var.enable_s3_endpoint ? 1 : 0}"
+  count = "${var.create_vpc && var.enable_s3_endpoint && length(var.intra_subnets) > 0 ? 1 : 0}"
 
   vpc_endpoint_id = "${aws_vpc_endpoint.s3.id}"
   route_table_id  = "${element(aws_route_table.intra.*.id, 0)}"
@@ -323,7 +323,7 @@ resource "aws_vpc_endpoint_route_table_association" "private_dynamodb" {
 }
 
 resource "aws_vpc_endpoint_route_table_association" "intra_dynamodb" {
-  count = "${var.create_vpc && var.enable_dynamodb_endpoint ? 1 : 0}"
+  count = "${var.create_vpc && var.enable_dynamodb_endpoint && length(var.intra_subnets) > 0 ? 1 : 0}"
 
   vpc_endpoint_id = "${aws_vpc_endpoint.dynamodb.id}"
   route_table_id  = "${element(aws_route_table.intra.*.id, 0)}"

Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ resource "aws_vpc_endpoint_route_table_association" "private_s3" {`
`286`	`286`	`}`
`287`	`287`
`288`	`288`	`resource "aws_vpc_endpoint_route_table_association" "intra_s3" {`
`289`		`- count = "${var.create_vpc && var.enable_s3_endpoint ? 1 : 0}"`
	`289`	`+ count = "${var.create_vpc && var.enable_s3_endpoint && length(var.intra_subnets) > 0 ? 1 : 0}"`
`290`	`290`
`291`	`291`	`vpc_endpoint_id = "${aws_vpc_endpoint.s3.id}"`
`292`	`292`	`route_table_id = "${element(aws_route_table.intra.*.id, 0)}"`
`@@ -323,7 +323,7 @@ resource "aws_vpc_endpoint_route_table_association" "private_dynamodb" {`
`323`	`323`	`}`
`324`	`324`
`325`	`325`	`resource "aws_vpc_endpoint_route_table_association" "intra_dynamodb" {`
`326`		`- count = "${var.create_vpc && var.enable_dynamodb_endpoint ? 1 : 0}"`
	`326`	`+ count = "${var.create_vpc && var.enable_dynamodb_endpoint && length(var.intra_subnets) > 0 ? 1 : 0}"`
`327`	`327`
`328`	`328`	`vpc_endpoint_id = "${aws_vpc_endpoint.dynamodb.id}"`
`329`	`329`	`route_table_id = "${element(aws_route_table.intra.*.id, 0)}"`