fix: enhance executable not found check (microsoft#572)

Author: mxschmitt

playwright/_impl/_browser_type.py

@@ -69,7 +69,7 @@ async def launch(
         try:
             return from_channel(await self._channel.send("launch", params))
         except Exception as e:
-            if f"{self.name}-" in str(e):
+            if "because executable doesn't exist" in str(e):
                 raise not_installed_error(f'"{self.name}" browser was not found.')
             raise e
 
@@ -124,7 +124,7 @@ async def launch_persistent_context(
             context._options = params
             return context
         except Exception as e:
-            if f"{self.name}-" in str(e):
+            if "because executable doesn't exist" in str(e):
                 raise not_installed_error(f'"{self.name}" browser was not found.')
             raise e
 

playwright/_impl/_helper.py

@@ -203,7 +203,7 @@ def is_safe_close_error(error: Exception) -> bool:
 
 
 def not_installed_error(message: str) -> Exception:
-    return Exception(
+    return Error(
         f"""
 ================================================================================
 {message}

tests/async/test_launcher.py

@@ -117,3 +117,12 @@ async def test_browser_close_should_be_callable_twice(browser_type, launch_argum
         browser.close(),
     )
     await browser.close()
+
+
+async def test_browser_launch_non_existing_executable_path_shows_install_msg(
+    browser_type,
+    tmpdir,
+):
+    with pytest.raises(Error) as exc_info:
+        await browser_type.launch(executable_path=tmpdir.join("executable"))
+    assert "python -m playwright install" in exc_info.value.message