Skip to content

Commit 27b9662

Browse files
Kshitij KansalKshitij Kansal
Kshitij Kansal
authored and
Kshitij Kansal
committed
Dereference null return value: Suggested changes made
1 parent aa0bd53 commit 27b9662

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,6 +338,7 @@ public void run() {
338338
return;
339339
}
340340
s_logger.debug("Starting SAML IDP Metadata Refresh Task");
341+
341342
Map <String, SAMLProviderMetadata> metadataMap = new HashMap<String, SAMLProviderMetadata>();
342343
try {
343344
discoverAndAddIdp(_idpMetaDataProvider.getMetadata(), metadataMap);
@@ -369,7 +370,7 @@ private boolean setup() {
369370
} else {
370371
File metadataFile = PropertiesUtil.findConfigFile(idpMetaDataUrl);
371372
if (metadataFile == null) {
372-
s_logger.error("Metadata file returned null");
373+
s_logger.error("Provided Metadata is not a URL, Unable to locate metadata file from local path: " + idpMetaDataUrl);
373374
return false;
374375
}
375376
else{

0 commit comments

Comments
 (0)