Fix #377 - undefined variables (#417)

* Fix #377 - undefined variables & remove tests for php 7.1

Co-authored-by: Dawid 'DeyV' Polak <[email protected]>

Author: DeyV

.github/workflows/test.yml

@@ -12,17 +12,16 @@ jobs:
       fail-fast: false
       matrix:
         php-version:
-          - php: '7.1'
-            phpunit: '7.5'
           - php: '7.2'
-            phpunit: '8'
+            phpunit: '8' 
           - php: '7.3'
-            phpunit: latest
+            phpunit: latest 
           - php: '7.4'
-            phpunit: latest
+            phpunit: latest 
           - php: '8.0'
-            phpunit: latest
-
+            phpunit: latest 
+          - php: '8.1'
+            phpunit: latest 
     steps:
       - uses: actions/checkout@v2
       - uses: php-actions/composer@v6

composer.json

@@ -24,11 +24,13 @@
 	"require" : {
 		"php" : ">=7.1.0",
 		"ext-curl" : "*",
+		"ext-dom"  : "*",
 		"psr/log" : "^1.0 || ^2.0 || ^3.0"
-	},
+    },
 	"require-dev" : {
 		"monolog/monolog" : "^1.0.0",
-		"phpunit/phpunit" : ">=7.5"
+		"phpunit/phpunit" : ">=7.5", 
+		"phpstan/phpstan" : "^1.5"
 	},
 	"autoload" : {
 		"classmap" : [
@@ -42,7 +44,8 @@
 		}
 	},
 	"scripts" : {
-		"test" : "phpunit"
+		"test" : "phpunit", 
+		"phpstan" : "phpstan"
 	},
 	"extra" : {
 		"branch-alias" : {

source/CAS/Client.php

@@ -1573,7 +1573,7 @@ public function isAuthenticated($renew=false)
     {
         phpCAS::traceBegin();
         $res = false;
-        $validate_url = '';
+
         if ( $this->_wasPreviouslyAuthenticated() ) {
             if ($this->hasTicket()) {
                 // User has a additional ticket but was already authenticated
@@ -1607,6 +1607,10 @@ public function isAuthenticated($renew=false)
             $this->markAuthenticationCall($res);
         } else {
             if ($this->hasTicket()) {
+                $validate_url = '';
+                $text_response = '';
+                $tree_response = '';
+
                 switch ($this->getServerVersion()) {
                 case CAS_VERSION_1_0:
                     // if a Service Ticket was given, validate it
@@ -1670,7 +1674,7 @@ public function isAuthenticated($renew=false)
                     $logoutTicket = $this->getTicket();
                     break;
                 default:
-                    phpCAS::trace('Protocoll error');
+                    phpCAS::trace('Protocol error');
                     break;
                 }
             } else {
@@ -2179,6 +2183,8 @@ public function validateCAS10(&$validate_url,&$text_response,&$tree_response,$re
             $validate_url .= '&renew=true';
         }
 
+        $headers = '';
+        $err_msg = '';
         // open and read the URL
         if ( !$this->_readURL($validate_url, $headers, $text_response, $err_msg) ) {
             phpCAS::trace(
@@ -2255,6 +2261,8 @@ public function validateSA(&$validate_url,&$text_response,&$tree_response,$renew
             $validate_url .= '&renew=true';
         }
 
+        $headers = '';
+        $err_msg = '';
         // open and read the URL
         if ( !$this->_readURL($validate_url, $headers, $text_response, $err_msg) ) {
             phpCAS::trace(
@@ -2912,6 +2920,8 @@ public function retrievePT($target_service,&$err_code,&$err_msg)
         $cas_url = $this->getServerProxyURL().'?targetService='
             .urlencode($target_service).'&pgt='.$this->_getPGT();
 
+        $headers = '';
+        $cas_response = '';
         // open and read the URL
         if ( !$this->_readURL($cas_url, $headers, $cas_response, $err_msg) ) {
             phpCAS::trace(