Skip to content

Commit 2c55644

Browse files
committed
fixed sanitization of watched value
1 parent 38889d6 commit 2c55644

File tree

3 files changed

+19
-11
lines changed

3 files changed

+19
-11
lines changed

Gruntfile.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,4 +128,10 @@ module.exports = function(grunt) {
128128
'uglify'
129129
]);
130130

131+
grunt.registerTask('check', [
132+
'jsonlint',
133+
'jscs',
134+
'jshint'
135+
]);
136+
131137
};

dist/angular-pdf.js

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,33 +47,35 @@
4747
};
4848

4949
scope.goPrevious = function() {
50-
if (scope.pageNum <= 1) {
50+
if (scope.pageToDisplay <= 1) {
5151
return;
5252
}
53-
scope.pageNum = parseInt(scope.pageNum, 10) - 1;
53+
scope.pageToDisplay = scope.pageToDisplay - 1;
54+
scope.renderPage(scope.pageToDisplay);
5455
};
5556

5657
scope.goNext = function() {
57-
if (scope.pageNum >= pdfDoc.numPages) {
58+
if (scope.pageToDisplay >= pdfDoc.numPages) {
5859
return;
5960
}
60-
scope.pageNum = parseInt(scope.pageNum, 10) + 1;
61+
scope.pageToDisplay = scope.pageToDisplay + 1;
62+
scope.renderPage(scope.pageToDisplay);
6163
};
6264

6365
scope.zoomIn = function() {
6466
scale = parseFloat(scale) + 0.2;
65-
scope.renderPage(scope.pageNum);
67+
scope.renderPage(scope.pageToDisplay);
6668
return scale;
6769
};
6870

6971
scope.zoomOut = function() {
7072
scale = parseFloat(scale) - 0.2;
71-
scope.renderPage(scope.pageNum);
73+
scope.renderPage(scope.pageToDisplay);
7274
return scale;
7375
};
7476

7577
scope.changePage = function() {
76-
scope.renderPage(scope.pageNum);
78+
scope.renderPage(scope.pageToDisplay);
7779
};
7880

7981
scope.rotate = function() {
@@ -90,17 +92,17 @@
9092

9193
PDFJS.getDocument(url).then(function(_pdfDoc) {
9294
pdfDoc = _pdfDoc;
93-
scope.renderPage(scope.pageNum);
95+
scope.renderPage(scope.pageToDisplay);
9496

9597
scope.$apply(function() {
9698
scope.pageCount = _pdfDoc.numPages;
9799
});
98100
});
99101

100102
scope.$watch('pageNum', function(newVal) {
101-
scope.pageNum = parseInt(newVal);
103+
scope.pageToDisplay = parseInt(newVal);
102104
if (pdfDoc !== null) {
103-
scope.renderPage(scope.pageNum);
105+
scope.renderPage(scope.pageToDisplay);
104106
}
105107
});
106108

dist/angular-pdf.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)