Deprecate one-arg coercion

Author: rmosolgo

lib/graphql/base_type.rb

@@ -97,7 +97,6 @@ def to_s
 
     alias :inspect :to_s
 
-    # Use this in places where there is no `ctx`
     def valid_isolated_input?(value)
       valid_input?(value, GraphQL::Query::NullContext)
     end
@@ -114,22 +113,36 @@ def coerce_isolated_result(value)
       coerce_result(value, GraphQL::Query::NullContext)
     end
 
-    def valid_input?(value, ctx)
+    def valid_input?(value, ctx = nil)
+      if ctx.nil?
+        warn_deprecated_coerce("valid_isolated_input?")
+        ctx = GraphQL::Query::NullContext
+      end
+
       validate_input(value, ctx).valid?
     end
 
-    def validate_input(value, ctx)
+    def validate_input(value, ctx = nil)
+      if ctx.nil?
+        warn_deprecated_coerce("validate_isolated_input")
+        ctx = GraphQL::Query::NullContext
+      end
+
       if value.nil?
         GraphQL::Query::InputValidationResult.new
       else
         validate_non_null_input(value, ctx)
       end
     end
 
-    def coerce_input(value, ctx)
+    def coerce_input(value, ctx = nil)
       if value.nil?
         nil
       else
+        if ctx.nil?
+          warn_deprecated_coerce("coerce_isolated_input")
+          ctx = GraphQL::Query::NullContext
+        end
         coerce_non_null_input(value, ctx)
       end
     end
@@ -192,5 +205,11 @@ def to_definition(schema, printer: nil, **args)
       printer ||= GraphQL::Schema::Printer.new(schema, **args)
       printer.print_type(self)
     end
+
+    private
+
+    def warn_deprecated_coerce(alt_method_name)
+      warn("Coercing without a context is deprecated; use `#{alt_method_name}` if you don't want context-awareness")
+    end
   end
 end

lib/graphql/enum_type.rb

@@ -133,7 +133,12 @@ def coerce_non_null_input(value_name, ctx)
       end
     end
 
-    def coerce_result(value, ctx)
+    def coerce_result(value, ctx = nil)
+      if ctx.nil?
+        warn_deprecated_coerce("coerce_isolated_result")
+        ctx = GraphQL::Query::NullContext
+      end
+
       warden = ctx.warden
       all_values = warden ? warden.enum_values(self) : @values_by_name.each_value
       enum_value = all_values.find { |val| val.value == value }

lib/graphql/input_object_type.rb

@@ -104,7 +104,12 @@ def coerce_non_null_input(value, ctx)
       GraphQL::Query::Arguments.new(input_values, argument_definitions: arguments)
     end
 
-    def coerce_result(value, ctx = GraphQL::Query::NullContext)
+    def coerce_result(value, ctx = nil)
+      if ctx.nil?
+        warn_deprecated_coerce("coerce_isolated_result")
+        ctx = GraphQL::Query::NullContext
+      end
+
       # Allow the application to provide values as :symbols, and convert them to the strings
       value = value.reduce({}) { |memo, (k, v)| memo[k.to_s] = v; memo }
 

lib/graphql/list_type.rb

@@ -57,7 +57,11 @@ def coerce_non_null_input(value, ctx)
       ensure_array(value).map { |item| of_type.coerce_input(item, ctx) }
     end
 
-    def coerce_result(value, ctx)
+    def coerce_result(value, ctx = nil)
+      if ctx.nil?
+        warn_deprecated_coerce("coerce_isolated_result")
+        ctx = GraphQL::Query::NullContext
+      end
       ensure_array(value).map { |item| item.nil? ? nil : of_type.coerce_result(item, ctx) }
     end
 

lib/graphql/scalar_type.rb

@@ -66,19 +66,23 @@ def coerce_non_null_input(value, ctx = GraphQL::Query::NullContext)
       @coerce_input_proc.call(value, ctx)
     end
 
-    def coerce_input=(proc)
-      if !proc.nil?
-        @coerce_input_proc = ensure_two_arg(proc)
+    def coerce_input=(coerce_input_fn)
+      if !coerce_input_fn.nil?
+        @coerce_input_proc = ensure_two_arg(coerce_input_fn, :coerce_input)
       end
     end
 
-    def coerce_result(value, ctx = GraphQL::Query::NullContext)
+    def coerce_result(value, ctx = nil)
+      if ctx.nil?
+        warn_deprecated_coerce("coerce_isolated_result")
+        ctx = GraphQL::Query::NullContext
+      end
       @coerce_result_proc.call(value, ctx)
     end
 
-    def coerce_result=(proc)
-      if !proc.nil?
-        @coerce_result_proc = ensure_two_arg(proc)
+    def coerce_result=(coerce_result_fn)
+      if !coerce_result_fn.nil?
+        @coerce_result_proc = ensure_two_arg(coerce_result_fn, :coerce_result)
       end
     end
 
@@ -97,8 +101,9 @@ def get_arity(callable)
       end
     end
 
-    def ensure_two_arg(callable)
+    def ensure_two_arg(callable, method_name)
       if get_arity(callable) == 1
+        warn("Scalar coerce functions receive two values (`val` and `ctx`), one-argument functions are deprecated (see #{name}.#{method_name}).")
         ->(val, ctx) { callable.call(val) }
       else
         callable