fix(Schema#raise_definition_errors) add compatibility option; default true for loaded schemas

Author: rmosolgo

lib/graphql/schema.rb

@@ -58,6 +58,7 @@ class Schema
       :query_execution_strategy, :mutation_execution_strategy, :subscription_execution_strategy,
       :max_depth, :max_complexity,
       :orphan_types, :resolve_type, :type_error, :parse_error,
+      :raise_definition_error,
       :object_from_id, :id_from_object,
       :default_mask,
       :cursor_encoder,
@@ -74,7 +75,8 @@ class Schema
       :max_depth, :max_complexity,
       :orphan_types, :directives,
       :query_analyzers, :instrumenters, :lazy_methods,
-      :cursor_encoder
+      :cursor_encoder,
+      :raise_definition_error
 
     # @return [MiddlewareChain] MiddlewareChain which is applied to fields during execution
     attr_accessor :middleware
@@ -179,8 +181,12 @@ def define(**kwargs, &block)
       @definition_error = nil
       nil
     rescue StandardError => err
-      # Raise this error _later_ to avoid messing with Rails constant loading
-      @definition_error = err
+      if @raise_definition_error
+        raise
+      else
+        # Raise this error _later_ to avoid messing with Rails constant loading
+        @definition_error = err
+      end
       nil
     end
 

lib/graphql/schema/build_from_definition.rb

@@ -105,6 +105,8 @@ def build(document, default_resolve: DefaultResolve)
           raise InvalidDocumentError.new('Must provide schema definition with query type or a type named Query.') unless query_root_type
 
           Schema.define do
+            raise_definition_error true
+
             query query_root_type
             mutation mutation_root_type
             subscription subscription_root_type

lib/graphql/schema/loader.rb

@@ -30,7 +30,7 @@ def load(introspection_result)
           kargs[root] = types.fetch(type.fetch("name")) if type
         end
 
-        Schema.define(**kargs)
+        Schema.define(**kargs, raise_definition_error: true)
       end
 
       NullResolveType = ->(obj, ctx) {

spec/graphql/field_spec.rb

@@ -90,7 +90,7 @@ def acts_like_default_resolver(field, old_prop, new_prop)
       dummy_query.fields["symbol_name"] = invalid_field
 
       err = assert_raises(GraphQL::Schema::InvalidTypeError) {
-        GraphQL::Schema.define(query: dummy_query)
+        GraphQL::Schema.define(query: dummy_query, raise_definition_error: true)
       }
       assert_equal "QueryType is invalid: field :symbol_name name must return String, not Symbol (:symbol_name)", err.message
     end