Merge pull request rmosolgo#661 from gjtorikian/get-wild-get-angry

Raise on UTF-8 encoding error

Author: rmosolgo

lib/graphql.rb

@@ -9,6 +9,9 @@ module GraphQL
   class Error < StandardError
   end
 
+  class CoercionError < Error
+  end
+
   class ParseError < Error
     attr_reader :line, :col, :query
     def initialize(message, line, col, query)

lib/graphql/string_type.rb

@@ -5,7 +5,8 @@
 
   coerce_result ->(value) {
     str = value.to_s
-    str.encoding == Encoding::US_ASCII || str.encoding == Encoding::UTF_8 ? str : nil
+    return str if str.encoding == Encoding::US_ASCII || str.encoding == Encoding::UTF_8
+    raise GraphQL::CoercionError.new("The string `#{str}` was encoded as #{str.encoding}! GraphQL requires all strings to be UTF-8 encoded.")
   }
 
   coerce_input ->(value) { value.is_a?(String) ? value : nil }

spec/graphql/string_type_spec.rb

@@ -11,7 +11,9 @@
   describe "coerce_result" do
     it "requires string to be encoded as UTF-8" do
       binary_str = "\0\0\0foo\255\255\255".dup.force_encoding("BINARY")
-      assert_equal nil, string_type.coerce_result(binary_str)
+      assert_raises(GraphQL::CoercionError) {
+        assert_equal nil, string_type.coerce_result(binary_str)
+      }
     end
   end