Skip to content

Commit 5ae5961

Browse files
authored
chore: move to EventEmitter due deprecation warning (microsoft#214)
1 parent b4137f2 commit 5ae5961

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

playwright/connection.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@
1818
from typing import Any, Callable, Dict, Optional, Union
1919

2020
from greenlet import greenlet
21-
from pyee import BaseEventEmitter
21+
from pyee import EventEmitter
2222

2323
from playwright.helper import ParsedMessagePayload, parse_error
2424
from playwright.sync_base import dispatcher_fiber
2525
from playwright.transport import Transport
2626

2727

28-
class Channel(BaseEventEmitter):
28+
class Channel(EventEmitter):
2929
def __init__(self, connection: "Connection", guid: str) -> None:
3030
super().__init__()
3131
self._connection: Connection = connection
@@ -54,7 +54,7 @@ def send_no_reply(self, method: str, params: Dict = None) -> None:
5454
self._connection._send_message_to_server(self._guid, method, params)
5555

5656

57-
class ChannelOwner(BaseEventEmitter):
57+
class ChannelOwner(EventEmitter):
5858
def __init__(
5959
self,
6060
parent: Union["ChannelOwner", "Connection"],

playwright/frame.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from pathlib import Path
1818
from typing import TYPE_CHECKING, Any, Dict, List, Optional, Set, Union, cast
1919

20-
from pyee import BaseEventEmitter
20+
from pyee import EventEmitter
2121

2222
from playwright.connection import ChannelOwner, from_channel, from_nullable_channel
2323
from playwright.element_handle import (
@@ -73,7 +73,7 @@ def __init__(
7373
self._child_frames: List[Frame] = []
7474
self._page: "Page"
7575
self._load_states: Set[str] = set(initializer["loadStates"])
76-
self._event_emitter = BaseEventEmitter()
76+
self._event_emitter = EventEmitter()
7777
self._channel.on(
7878
"loadstate",
7979
lambda params: self._on_load_state(params.get("add"), params.get("remove")),

playwright/wait_helper.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import asyncio
1616
from typing import Any, Callable, List
1717

18-
from pyee import BaseEventEmitter
18+
from pyee import EventEmitter
1919

2020
from playwright.helper import Error, TimeoutError
2121

@@ -27,7 +27,7 @@ def __init__(self, loop: asyncio.AbstractEventLoop) -> None:
2727

2828
def reject_on_event(
2929
self,
30-
emitter: BaseEventEmitter,
30+
emitter: EventEmitter,
3131
event: str,
3232
error: Error,
3333
predicate: Callable[[Any], bool] = None,
@@ -52,7 +52,7 @@ async def future_wrapper() -> Error:
5252

5353
async def wait_for_event(
5454
self,
55-
emitter: BaseEventEmitter,
55+
emitter: EventEmitter,
5656
event: str,
5757
predicate: Callable[[Any], bool] = None,
5858
) -> Any:
@@ -75,7 +75,7 @@ async def wait_for_future(self, future: asyncio.Future) -> Any:
7575

7676

7777
def wait_for_event_future(
78-
emitter: BaseEventEmitter, event: str, predicate: Callable[[Any], bool] = None
78+
emitter: EventEmitter, event: str, predicate: Callable[[Any], bool] = None
7979
) -> asyncio.Future:
8080
future: asyncio.Future = asyncio.Future()
8181

0 commit comments

Comments
 (0)