Skip to content

Commit b700b4a

Browse files
authored
chore: user the driver from cdn (microsoft#227)
1 parent d1b6a1b commit b700b4a

16 files changed

+160
-17270
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,13 @@ jobs:
1515
uses: actions/setup-python@v2
1616
with:
1717
python-version: 3.8
18-
- name: Set up Node.js
19-
uses: actions/setup-node@v1
20-
with:
21-
node-version: 12.x
2218
- name: Install dependencies
2319
run: |
2420
python -m pip install --upgrade pip
2521
pip install -r local-requirements.txt
2622
pip install -e .
2723
- name: Lint
2824
run: pre-commit run --all-files
29-
- name: Build driver
30-
run: python build_driver.py
3125
- name: Test Sync generation script
3226
run: bash buildbots/test-sync-generation.sh
3327
build:
@@ -43,20 +37,6 @@ jobs:
4337
steps:
4438
- uses: actions/checkout@v2
4539
- uses: microsoft/playwright-github-action@v1
46-
- name: Set up Node.js
47-
uses: actions/setup-node@v1
48-
with:
49-
node-version: 12.x
50-
- name: Get Node PKG Cache dir
51-
id: node-pkg-cache
52-
run: |
53-
node -e "const path = require('path'); const fs = require('fs'); const cachePath = path.join(os.tmpdir(), 'pkg-cache'); fs.mkdirSync(cachePath); console.log('::set-output name=dir::' + cachePath)"
54-
- name: Cache driver
55-
id: cache-primes
56-
uses: actions/cache@v2
57-
with:
58-
path: ${{ steps.node-pkg-cache.outputs.dir }}
59-
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
6040
- name: Set up Python
6141
uses: actions/setup-python@v2
6242
with:
@@ -66,10 +46,6 @@ jobs:
6646
python -m pip install --upgrade pip
6747
pip install -r local-requirements.txt
6848
pip install -e .
69-
- name: Build driver
70-
run: python build_driver.py
71-
env:
72-
PKG_CACHE_PATH: ${{ steps.node-pkg-cache.outputs.dir }}
7349
- name: Build package
7450
run: python build_package.py
7551
- name: Install
@@ -107,8 +83,6 @@ jobs:
10783
python -m pip install --upgrade pip
10884
pip install -r local-requirements.txt
10985
pip install -e .
110-
- name: Build driver
111-
run: python build_driver.py
11286
- name: Build package
11387
run: python build_package.py
11488
- name: Test package installation

.github/workflows/publish.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
types: [published]
55
jobs:
66
deploy:
7-
runs-on: windows-latest
7+
runs-on: ubuntu-latest
88
steps:
99
- uses: actions/checkout@v2
1010
- uses: microsoft/playwright-github-action@v1
@@ -21,8 +21,6 @@ jobs:
2121
python -m pip install --upgrade pip
2222
pip install -r local-requirements.txt
2323
pip install -e .
24-
- name: Build driver
25-
run: python build_driver.py
2624
- name: Build package
2725
run: python build_package.py
2826
- name: Publish package

.gitignore

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
playwright/__pycache__/
2-
playwright/drivers/driver*
3-
playwright/driver-*
4-
driver/node_modules/
5-
driver/out/
6-
driver/package-lock.json
2+
driver/
3+
playwright/driver/
74
playwright.egg-info/
85
build/
96
dist/

0 commit comments

Comments
 (0)