Optimisations

Author: Gabriele Torini

bt_node.gd

@@ -71,13 +71,11 @@ func _ready():
 # You can use these as setters and getters for the BTNodeState of a BTNode
 func succeed() -> bool:
 	state.set_success()
-	emit_signal("tick", true)
-	return true
+    return true
 
 
 func fail() -> bool:
-	state.set_failure()
-	emit_signal("tick", false)
+    state.set_failure()
 	return false
 
 
@@ -106,13 +104,11 @@ func get_state() -> String:
 		return "running"
 
 
-func set_state(rhs: BTNode):
+func set_state(rhs: BTNode) -> bool:
 	if rhs.succeeded():
 		return succeed()
 	elif rhs.failed():
-		return fail()
-	else:
-		run()
+        return fail()
 
 
 # DO NOT override this
@@ -130,17 +126,13 @@ func tick(agent: Node, blackboard: Blackboard) -> bool:
 
 	var result = _tick(agent, blackboard)
 
-	if result is GDScriptFunctionState:
-		if not running():
-			push_error(name + " exited execution, but it's not running().")
-			assert(false)
-		
+    if result is GDScriptFunctionState:
+        assert(running())
 		result = yield(result, "completed")
 
-	if running():
-		push_error(name + " completed but it is still running(). Must either succeed() or fail().")
-		assert(false)
-	
+	assert(not running())
+    
+    emit_signal("tick", result)
 	return result
 
 

bt_random_selector.gd

@@ -8,9 +8,10 @@ extends BTComposite
 func _tick(agent: Node, blackboard: Blackboard) -> bool:
 	randomize()
 	var result
-	
-	for i in get_child_count():
-		var rand_idx = randi() % get_child_count()
+    var n_children = get_child_count()
+    
+	for i in n_children:
+		var rand_idx = randi() % n_children
 		bt_child = get_child(rand_idx)
 
 		result = bt_child.tick(agent, blackboard)