fix: approval screens for CreateChainTx + ConvertSubnetToL1 (#296)

Author: owenwahlgren

apps/legacy/src/localization/locales/en/translation.json

@@ -541,7 +541,6 @@
   "Manage Collectibles": "Manage Collectibles",
   "Manage Networks": "Manage Networks",
   "Manage Tokens": "Manage Tokens",
-  "Manager Address": "Manager Address",
   "Manually Create New Wallet": "Manually Create New Wallet",
   "Market News": "Market News",
   "Max Base Fee": "Max Base Fee",
@@ -887,8 +886,8 @@
   "Spendable Balance": "Spendable Balance",
   "Spender": "Spender",
   "Spending limit": "Spending limit",
-  "Stake": "Stake",
   "Stake Amount": "Stake Amount",
+  "Stake Weight": "Stake Weight",
   "Staked": "Staked",
   "Staking Details": "Staking Details",
   "Start": "Start",
@@ -1088,6 +1087,7 @@
   "User rejected the request": "User rejected the request",
   "Users may not use the Bridge if they are on the Specially Designated Nationals (SDN) List of the Office of Foreign Assets Control (OFAC) or any other sanctions or are otherwise a sanctioned person or from a sanctioned jurisdiction": "Users may not use the Bridge if they are on the Specially Designated Nationals (SDN) List of the Office of Foreign Assets Control (OFAC) or any other sanctions or are otherwise a sanctioned person or from a sanctioned jurisdiction",
   "Validation ID": "Validation ID",
+  "Validator Manager": "Validator Manager",
   "Validators": "Validators",
   "Value": "Value",
   "Verify": "Verify",

apps/legacy/src/pages/ApproveAction/components/ApproveConvertSubnetToL1.tsx

@@ -30,10 +30,15 @@ export function ApproveConvertSubnetToL1({
           <TxDetailsRow label={t('Subnet ID')}>
             <TruncatedIdentifier identifier={subnetID} size={14} />
           </TxDetailsRow>
-          <TxDetailsRow label={t('Chain ID')}>
+        </ApprovalSectionBody>
+      </ApprovalSection>
+      <ApprovalSection sx={{ gap: 1 }}>
+        <ApprovalSectionHeader label={t('Validator Manager')} />
+        <ApprovalSectionBody sx={{ justifyContent: 'start', py: 2.25 }}>
+          <TxDetailsRow label={t('Blockchain ID')}>
             <TruncatedIdentifier identifier={chainID} size={14} />
           </TxDetailsRow>
-          <TxDetailsRow label={t('Manager Address')}>
+          <TxDetailsRow label={t('Address')}>
             <TruncatedIdentifier identifier={managerAddress} size={14} />
           </TxDetailsRow>
         </ApprovalSectionBody>
@@ -59,8 +64,8 @@ export function ApproveConvertSubnetToL1({
                 <TxDetailsRow label={t('Balance')}>
                   <AvaxAmount amount={balance} avaxPrice={avaxPrice} />
                 </TxDetailsRow>
-                <TxDetailsRow label={t('Stake')}>
-                  <AvaxAmount amount={stake} avaxPrice={avaxPrice} />
+                <TxDetailsRow label={t('Stake Weight')}>
+                  <Typography variant="body2">{String(stake)}</Typography>
                 </TxDetailsRow>
                 <Stack sx={{ gap: 1, mb: 2 }}>
                   <Typography variant="caption" color="text.secondary">

apps/legacy/src/pages/ApproveAction/components/ApproveCreateChain.tsx

@@ -22,7 +22,7 @@ export function ApproveCreateChain({
   avaxPrice: number;
 }) {
   const { t } = useTranslation();
-  const { chainID, chainName, vmID, genesisData, txFee } = tx;
+  const { subnetID, chainName, vmID, genesisData, txFee } = tx;
 
   const [isGenesisFileShown, setIsGenesisFileShown] = useState(false);
 
@@ -37,11 +37,14 @@ export function ApproveCreateChain({
       <ApprovalSection sx={{ gap: 1 }}>
         <ApprovalSectionHeader label={t('Blockchain Details')} />
         <ApprovalSectionBody sx={{ justifyContent: 'start', py: 2.25 }}>
+          <TxDetailsRow label={t('Subnet ID')}>
+            <TruncatedIdentifier identifier={subnetID} />
+          </TxDetailsRow>
           <TxDetailsRow label={t('Blockchain Name')}>
             <Typography variant="caption">{chainName}</Typography>
           </TxDetailsRow>
-          <TxDetailsRow label={t('Blockchain ID')}>
-            <TruncatedIdentifier identifier={chainID} />
+          <TxDetailsRow label={t('Virtual Machine ID')}>
+            <TruncatedIdentifier identifier={vmID} />
           </TxDetailsRow>
           <TxDetailsRow label={t('Genesis File')}>
             <Button
@@ -52,9 +55,6 @@ export function ApproveCreateChain({
               {t('View')}
             </Button>
           </TxDetailsRow>
-          <TxDetailsRow label={t('Virtual Machine ID')}>
-            <TruncatedIdentifier identifier={vmID} />
-          </TxDetailsRow>
         </ApprovalSectionBody>
       </ApprovalSection>
       <ApprovalSection>

apps/legacy/src/pages/ApproveAction/components/BlockchainGenesisFile.tsx

@@ -49,7 +49,14 @@ export const BlockchainGenesisFile = ({ onClose, data }) => {
             <ApprovalSectionBody sx={{ flexGrow: 1 }}>
               <Scrollbars>
                 <Typography component="pre" variant="caption" monospace>
-                  {data}
+                  {(() => {
+                    try {
+                      const parsed = JSON.parse(data);
+                      return JSON.stringify(parsed, null, 2);
+                    } catch {
+                      return data;
+                    }
+                  })()}
                 </Typography>
               </Scrollbars>
             </ApprovalSectionBody>