Skip to content

Commit 027b328

Browse files
author
Himani Anil Deshpande
committed
[Efs-utils] Add efs-utils attributes
1 parent a39a551 commit 027b328

File tree

5 files changed

+21
-12
lines changed

5 files changed

+21
-12
lines changed

cookbooks/aws-parallelcluster-environment/attributes/environment.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,11 @@
7373
default['cluster']['efa']['version'] = '1.41.0'
7474
default['cluster']['efa']['sha256'] = '3506354cdfbe31ff552fe75f5d0d9bb7efd29cf79bd99457347d29c751c38f9f'
7575

76+
default['cluster']['efs']['version'] = '2.3.1'
77+
default['cluster']['efs']['sha256'] = 'ced12f82e76f9740476b63f30c49bd76cc00b6375e12a9f5f7ba852635c49e15'
78+
if platform?('amazon')
79+
default['cluster']['efs']['version'] = '2.1.0'
80+
end
7681
# TODO: Move to platform cookbook
7782
default['cluster']['spack_shared_dir'] = "#{node['cluster']['shared_dir']}/spack"
7883
default['cluster']['spack']['version'] = '0.20.2'

cookbooks/aws-parallelcluster-environment/resources/efs/efs_alinux2.rb

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,11 @@
1818
use 'partial/_common'
1919
use 'partial/_mount_umount'
2020

21-
property :efs_utils_version, String, default: '2.1.0'
22-
2321
action :install_utils do
2422
package_name = "amazon-efs-utils"
25-
full_package = "#{package_name}-#{new_resource.efs_utils_version}"
23+
full_package = "#{package_name}-#{_efs_utils_version}"
2624
# Do not install efs-utils if a same or newer version is already installed.
27-
return if already_installed?(package_name, new_resource.efs_utils_version)
25+
return if already_installed?(package_name, _efs_utils_version)
2826

2927
# On Amazon Linux 2, amazon-efs-utils and stunnel are installed from OS repo.
3028
package full_package do

cookbooks/aws-parallelcluster-environment/resources/efs/efs_alinux2023.rb

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,11 @@
2020
use 'partial/_common'
2121
use 'partial/_mount_umount'
2222

23-
property :efs_utils_version, String, default: '2.1.0'
24-
2523
action :install_utils do
26-
package_name = "amazon-efs-utils-#{new_resource.efs_utils_version}"
24+
package_name = "amazon-efs-utils-#{_efs_utils_version}"
2725

2826
# Do not install efs-utils if a same or newer version is already installed.
29-
return if already_installed?(package_name, new_resource.efs_utils_version)
27+
return if already_installed?(package_name, _efs_utils_version)
3028

3129
# On Amazon Linux 2, amazon-efs-utils and stunnel are installed from OS repo.
3230
package package_name do

cookbooks/aws-parallelcluster-environment/resources/efs/partial/_common.rb

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,16 @@
22

33
default_action :install_utils
44

5-
property :efs_utils_version, String, default: '2.3.1'
6-
property :efs_utils_checksum, String, default: 'ced12f82e76f9740476b63f30c49bd76cc00b6375e12a9f5f7ba852635c49e15'
5+
property :efs_utils_version, String
6+
property :efs_utils_checksum, String
7+
8+
def _efs_utils_version
9+
efs_utils_version || node['cluster']['efs']['version']
10+
end
11+
12+
def _efs_utils_checksum
13+
efs_utils_checksum || node['cluster']['efs']['sha256']
14+
end
715

816
def already_installed?(package_name, expected_version)
917
Gem::Version.new(get_package_version(package_name)) >= Gem::Version.new(expected_version)

cookbooks/aws-parallelcluster-environment/resources/efs/partial/_install_from_tar.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
return if redhat_on_docker?
3131

3232
package_name = "amazon-efs-utils"
33-
package_version = new_resource.efs_utils_version
33+
package_version = _efs_utils_version
3434
efs_utils_tarball = "#{node['cluster']['sources_dir']}/efs-utils-#{package_version}.tar.gz"
3535
efs_utils_url = "#{node['cluster']['artifacts_s3_url']}/dependencies/efs/v#{package_version}.tar.gz"
3636

@@ -46,7 +46,7 @@
4646
mode '0644'
4747
retries 3
4848
retry_delay 5
49-
checksum new_resource.efs_utils_checksum
49+
checksum _efs_utils_checksum
5050
action :create_if_missing
5151
end
5252

0 commit comments

Comments
 (0)