Improve error logging in case of KeyError and AttributeError

Signed-off-by: Enrico Usai <[email protected]>

Author: enrico-usai

cookbooks/aws-parallelcluster-slurm/files/default/head_node_slurm/slurm/pcluster_fleet_config_generator.py

@@ -13,6 +13,7 @@
 import copy
 import json
 import logging
+import traceback
 
 import yaml
 
@@ -139,11 +140,13 @@ def generate_fleet_config_file(output_file, input_file):
 
                 fleet_config[queue][compute_resource] = config_for_fleet
 
-    except KeyError as e:
-        message = f"Unable to find key {e} in the configuration"
-        message += f" of queue: {queue}" if queue else " file"
-        message += f", compute resource: {compute_resource}" if compute_resource else ""
-
+    except (KeyError, AttributeError) as e:
+        if isinstance(e, KeyError):
+            message = f"Unable to find key {e} in the configuration file."
+        else:
+            message = f"Error parsing configuration file. {e}. {traceback.format_exc()}."
+        message += f" Queue: {queue}" if queue else ""
+        message += f" Compute resource: {compute_resource}" if compute_resource else ""
         log.error(message)
         raise CriticalError(message)
 

test/unit/slurm/test_fleet_config_generator.py

@@ -29,12 +29,12 @@
         (
             {"Scheduling": {"SlurmQueues": [{"Name": "q1"}]}},
             CriticalError,
-            "Unable to find key 'ComputeResources' in the configuration of queue: q1",
+            "Unable to find key 'ComputeResources' in the configuration file. Queue: q1",
         ),
         (
             {"Scheduling": {"SlurmQueues": [{"Name": "q1", "CapacityType": "ONDEMAND"}]}},
             CriticalError,
-            "Unable to find key 'ComputeResources' in the configuration of queue: q1",
+            "Unable to find key 'ComputeResources' in the configuration file. Queue: q1",
         ),
         ({"Scheduling": {"SlurmQueues": [{"Name": "q1", "CapacityType": "SPOT", "ComputeResources": []}]}}, None, None),
         (
@@ -44,7 +44,7 @@
                 }
             },
             CriticalError,
-            "Unable to find key 'Name' in the configuration of queue: q1",
+            "Unable to find key 'Name' in the configuration file. Queue: q1",
         ),
         (
             {
@@ -137,7 +137,7 @@
                 }
             },
             CriticalError,
-            "Unable to find key 'SpotPrice' in the configuration of queue: q1, compute resource: cr1",
+            "Unable to find key 'SpotPrice' in the configuration file. Queue: q1 Compute resource: cr1",
         ),
         (
             {
@@ -172,7 +172,7 @@
                 }
             },
             CriticalError,
-            "Unable to find key 'Networking' in the configuration of queue: q1, compute resource: cr1",
+            "Unable to find key 'Networking' in the configuration file. Queue: q1 Compute resource: cr1",
         ),
         (
             {
@@ -190,7 +190,7 @@
                 }
             },
             CriticalError,
-            "Unable to find key 'SubnetIds' in the configuration of queue: q1, compute resource: cr1",
+            "Unable to find key 'SubnetIds' in the configuration file. Queue: q1 Compute resource: cr1",
         ),
         (
             {