Skip to content

Commit ca66496

Browse files
committed
remove bucket accelerate config
1 parent 360405b commit ca66496

File tree

2 files changed

+6
-47
lines changed

2 files changed

+6
-47
lines changed

test/s3-tests/src/it/java/software/amazon/awssdk/services/s3/regression/S3ChecksumsTestUtils.java

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import software.amazon.awssdk.regions.Region;
3535
import software.amazon.awssdk.services.s3.S3AsyncClient;
3636
import software.amazon.awssdk.services.s3.S3Client;
37-
import software.amazon.awssdk.services.s3.model.BucketAccelerateStatus;
3837
import software.amazon.awssdk.services.s3.model.BucketLocationConstraint;
3938
import software.amazon.awssdk.services.s3.model.CreateBucketConfiguration;
4039
import software.amazon.awssdk.services.s3.model.CreateBucketRequest;
@@ -62,8 +61,6 @@ private S3ChecksumsTestUtils() {
6261
public static String createBucket(S3Client s3, String name, Logger log) {
6362
log.debug(() -> "Creating bucket: " + name);
6463
createBucket(s3, name, 3, log);
65-
s3.putBucketAccelerateConfiguration(r -> r.bucket(name)
66-
.accelerateConfiguration(c -> c.status(BucketAccelerateStatus.ENABLED)));
6764
return name;
6865
}
6966

@@ -193,22 +190,6 @@ public static void assumeNotAccessPointWithPathStyle(TestConfig config) {
193190
"Path style doesn't work with ARN type buckets");
194191
}
195192

196-
public static void assumeNotAccelerateWithPathStyle(TestConfig config) {
197-
Assumptions.assumeFalse(config.isForcePathStyle() && config.isAccelerateEnabled(),
198-
"Path style doesn't work with Accelerate");
199-
}
200-
201-
public static void assumeNotAccelerateWithArnType(TestConfig config) {
202-
Assumptions.assumeFalse(config.isAccelerateEnabled() && config.getBucketType().isArnType(),
203-
"Accelerate doesn't work with ARN buckets");
204-
}
205-
206-
public static void assumeNotAccelerateWithEoz(TestConfig config) {
207-
Assumptions.assumeFalse(config.isAccelerateEnabled() && config.getBucketType() == BucketType.EOZ,
208-
"Accelerate is not supported with Express One Zone");
209-
}
210-
211-
212193
public static String crc32(String s) {
213194
return crc32(s.getBytes(StandardCharsets.UTF_8));
214195
}
@@ -245,7 +226,6 @@ public static S3Client makeSyncClient(TestConfig config, Region region, AwsCrede
245226
.requestChecksumCalculation(config.getRequestChecksumValidation())
246227
.region(region)
247228
.credentialsProvider(provider)
248-
.accelerate(config.isAccelerateEnabled())
249229
.build();
250230
default:
251231
throw new RuntimeException("Unsupported sync flavor: " + config.getFlavor());
@@ -260,15 +240,13 @@ public static S3AsyncClient makeAsyncClient(TestConfig config, Region region, Aw
260240
.requestChecksumCalculation(config.getRequestChecksumValidation())
261241
.region(region)
262242
.credentialsProvider(provider)
263-
.accelerate(config.isAccelerateEnabled())
264243
.build();
265244
case MULTIPART_ENABLED:
266245
return S3AsyncClient.builder()
267246
.forcePathStyle(config.isForcePathStyle())
268247
.requestChecksumCalculation(config.getRequestChecksumValidation())
269248
.region(region)
270249
.credentialsProvider(provider)
271-
.accelerate(config.isAccelerateEnabled())
272250
.multipartEnabled(true)
273251
.build();
274252
case CRT_BASED: {
@@ -277,7 +255,6 @@ public static S3AsyncClient makeAsyncClient(TestConfig config, Region region, Aw
277255
.requestChecksumCalculation(config.getRequestChecksumValidation())
278256
.region(region)
279257
.credentialsProvider(provider)
280-
.accelerate(config.isAccelerateEnabled())
281258
.build();
282259
}
283260
default:
@@ -295,7 +272,6 @@ public static S3Client makeSyncClient(TestConfig config, ClientOverrideConfigura
295272
.requestChecksumCalculation(config.getRequestChecksumValidation())
296273
.region(region)
297274
.credentialsProvider(provider)
298-
.accelerate(config.isAccelerateEnabled())
299275
.build();
300276
default:
301277
throw new RuntimeException("Unsupported sync flavor: " + config.getFlavor());
@@ -312,7 +288,6 @@ public static S3AsyncClient makeAsyncClient(TestConfig config, ClientOverrideCon
312288
.requestChecksumCalculation(config.getRequestChecksumValidation())
313289
.region(region)
314290
.credentialsProvider(provider)
315-
.accelerate(config.isAccelerateEnabled())
316291
.build();
317292
case MULTIPART_ENABLED:
318293
return S3AsyncClient.builder()
@@ -321,7 +296,6 @@ public static S3AsyncClient makeAsyncClient(TestConfig config, ClientOverrideCon
321296
.requestChecksumCalculation(config.getRequestChecksumValidation())
322297
.region(region)
323298
.credentialsProvider(provider)
324-
.accelerate(config.isAccelerateEnabled())
325299
.multipartEnabled(true)
326300
.build();
327301
case CRT_BASED: {
@@ -330,7 +304,6 @@ public static S3AsyncClient makeAsyncClient(TestConfig config, ClientOverrideCon
330304
.requestChecksumCalculation(config.getRequestChecksumValidation())
331305
.region(region)
332306
.credentialsProvider(provider)
333-
.accelerate(config.isAccelerateEnabled())
334307
.build();
335308
}
336309
default:

test/s3-tests/src/it/java/software/amazon/awssdk/services/s3/regression/TestConfig.java

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ public class TestConfig {
2424
private BucketType bucketType;
2525
private boolean forcePathStyle;
2626
private RequestChecksumCalculation requestChecksumValidation;
27-
private boolean accelerateEnabled;
2827

2928
public S3ClientFlavor getFlavor() {
3029
return flavor;
@@ -58,22 +57,13 @@ public void setRequestChecksumValidation(RequestChecksumCalculation requestCheck
5857
this.requestChecksumValidation = requestChecksumValidation;
5958
}
6059

61-
public boolean isAccelerateEnabled() {
62-
return accelerateEnabled;
63-
}
64-
65-
public void setAccelerateEnabled(boolean accelerateEnabled) {
66-
this.accelerateEnabled = accelerateEnabled;
67-
}
68-
6960
@Override
7061
public String toString() {
7162
return "[" +
7263
"flavor=" + flavor +
7364
", bucketType=" + bucketType +
7465
", forcePathStyle=" + forcePathStyle +
7566
", requestChecksumValidation=" + requestChecksumValidation +
76-
", accelerateEnabled=" + accelerateEnabled +
7767
']';
7868
}
7969

@@ -83,20 +73,16 @@ public static List<TestConfig> testConfigs() {
8373
boolean[] forcePathStyle = {true, false};
8474
RequestChecksumCalculation[] checksumValidations = {RequestChecksumCalculation.WHEN_REQUIRED,
8575
RequestChecksumCalculation.WHEN_SUPPORTED};
86-
boolean[] accelerateEnabled = {true, false};
8776
for (boolean pathStyle : forcePathStyle) {
8877
for (RequestChecksumCalculation checksumValidation : checksumValidations) {
8978
for (S3ClientFlavor flavor : S3ClientFlavor.values()) {
9079
for (BucketType bucketType : BucketType.values()) {
91-
for (boolean accelerate : accelerateEnabled) {
92-
TestConfig testConfig = new TestConfig();
93-
testConfig.setFlavor(flavor);
94-
testConfig.setBucketType(bucketType);
95-
testConfig.setForcePathStyle(pathStyle);
96-
testConfig.setRequestChecksumValidation(checksumValidation);
97-
testConfig.setAccelerateEnabled(accelerate);
98-
configs.add(testConfig);
99-
}
80+
TestConfig testConfig = new TestConfig();
81+
testConfig.setFlavor(flavor);
82+
testConfig.setBucketType(bucketType);
83+
testConfig.setForcePathStyle(pathStyle);
84+
testConfig.setRequestChecksumValidation(checksumValidation);
85+
configs.add(testConfig);
10086
}
10187
}
10288
}

0 commit comments

Comments
 (0)