Skip to content

Commit d28cdac

Browse files
authored
Merge pull request mixcloud#172 from enjoy2000/master
Fix migration on_delete
2 parents ec1982a + d68c300 commit d28cdac

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

experiments/migrations/0001_initial.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@ class Migration(migrations.Migration):
3939
migrations.AddField(
4040
model_name='enrollment',
4141
name='experiment',
42-
field=models.ForeignKey(to='experiments.Experiment'),
42+
field=models.ForeignKey(to='experiments.Experiment', on_delete=django.db.models.deletion.CASCADE),
4343
),
4444
migrations.AddField(
4545
model_name='enrollment',
4646
name='user',
47-
field=models.ForeignKey(to=settings.AUTH_USER_MODEL),
47+
field=models.ForeignKey(to=settings.AUTH_USER_MODEL, on_delete=django.db.models.deletion.CASCADE),
4848
),
4949
migrations.AlterUniqueTogether(
5050
name='enrollment',

experiments/templatetags/experiments.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from __future__ import absolute_import
22

33
from django import template
4-
from django.core.urlresolvers import reverse
4+
from django.urls import reverse
55

66
from experiments.utils import participant
77
from experiments.manager import experiment_manager
@@ -101,7 +101,7 @@ def experiment(parser, token):
101101
return ExperimentNode(node_list, experiment_name, alternative, weight, user_variable)
102102

103103

104-
@register.assignment_tag(takes_context=True)
104+
@register.simple_tag(takes_context=True)
105105
def experiment_enroll(context, experiment_name, *alternatives, **kwargs):
106106
if 'user' in kwargs:
107107
user = participant(user=kwargs['user'])

experiments/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def _get_participant(request, session, user):
4343

4444
if request and conf.BOT_REGEX.search(request.META.get("HTTP_USER_AGENT", "")):
4545
return DummyUser()
46-
elif user and user.is_authenticated():
46+
elif user and user.is_authenticated:
4747
if getattr(user, 'is_confirmed_human', True):
4848
return AuthenticatedUser(user, request)
4949
else:

0 commit comments

Comments
 (0)