Issue ESAPI#300 -- Fixed a tricky polymorphism bug with Jeremiah Stacey's help. Added a unit test for PercentCodec.

Author: xeno6696

src/main/java/org/owasp/esapi/codecs/JavaScriptCodec.java

@@ -87,7 +87,7 @@ public String encodeCharacter( char[] immune, Character c ) {
 	 *   \\uHHHH
 	 *   \\OOO (1, 2, or 3 digits)
 	 */
-	public Character decodeCharacter( PushbackString input ) {
+	public Character decodeCharacter( PushbackSequence<Character> input ) {
 		input.mark();
 		Character first = input.next();
 		if ( first == null ) {

src/main/java/org/owasp/esapi/codecs/MySQLCodec.java

@@ -162,7 +162,7 @@ private String encodeCharacterMySQL( Character c ) {
 	 *   In ANSI_MODE '' decodes to '
 	 *   In MYSQL_MODE \x decodes to x (or a small list of specials)
 	 */
-	public Character decodeCharacter( PushbackString input ) {
+	public Character decodeCharacter( PushbackSequence<Character> input ) {
 		switch( mode ) {
 			case ANSI: return decodeCharacterANSI( input );
 			case STANDARD: return decodeCharacterMySQL( input );

src/main/java/org/owasp/esapi/codecs/OracleCodec.java

@@ -59,7 +59,7 @@ public String encodeCharacter( char[] immune, Character c ) {
 	 * Formats all are legal
 	 *   '' decodes to '
 	 */
-	public Character decodeCharacter( PushbackString input ) {
+	public Character decodeCharacter( PushbackSequence<Character> input ) {
 		input.mark();
 		Character first = input.next();
 		if ( first == null ) {

src/main/java/org/owasp/esapi/codecs/PercentCodec.java

@@ -128,7 +128,7 @@ public String encodeCharacter( char[] immune, Character c )
 	 * @param input
 	 * 			encoded character using percent characters (such as URL encoding)
 	 */
-	public Character decodeCharacter( PushbackString input ) {
+	public Character decodeCharacter( PushbackSequence<Character> input ) {
 		input.mark();
 		Character first = input.next();
 		if ( first == null ) {

src/main/java/org/owasp/esapi/codecs/UnixCodec.java

@@ -61,7 +61,7 @@ public String encodeCharacter( char[] immune, Character c ) {
 	 *   \x - all special characters
 	 *   
 	 */
-	public Character decodeCharacter( PushbackString input ) {
+	public Character decodeCharacter( PushbackSequence<Character> input ) {
 		input.mark();
 		Character first = input.next();
 		if ( first == null ) {

src/main/java/org/owasp/esapi/codecs/VBScriptCodec.java

@@ -96,7 +96,7 @@ public String encodeCharacter( char[] immune, Character c ) {
 	 *   "x - all special characters
 	 *   " + chr(x) + "  - not supported yet
 	 */
-	public Character decodeCharacter( PushbackString input ) {
+	public Character decodeCharacter( PushbackSequence<Character> input ) {
 		input.mark();
 		Character first = input.next();
 		if ( first == null ) {

src/main/java/org/owasp/esapi/codecs/WindowsCodec.java

@@ -61,7 +61,7 @@ public String encodeCharacter( char[] immune, Character c ) {
 	 * Formats all are legal both upper/lower case:
 	 *   ^x - all special characters
 	 */
-	public Character decodeCharacter( PushbackString input ) {
+	public Character decodeCharacter( PushbackSequence<Character> input ) {
 		input.mark();
 		Character first = input.next();
 		if ( first == null ) {

src/test/java/org/owasp/esapi/codecs/PercentCodecTest.java

@@ -0,0 +1,16 @@
+package org.owasp.esapi.codecs;
+
+import static org.junit.Assert.assertEquals;
+
+import org.junit.Test;
+
+public class PercentCodecTest {
+	
+	@Test
+	public void testPercentDecode(){
+		Codec codec = new PercentCodec();
+		
+		String expected = " ";
+		assertEquals(expected, codec.decode("%20"));
+	}
+}