Skip to content

Add support for experimental treatInternalAsPrivate and removePrivateClasses in abi.jar #1245

Open
@rbeazleyspot

Description

@rbeazleyspot

This is in relation to https://youtrack.jetbrains.com/issue/KT-65690 and https://youtrack.jetbrains.com/issue/KT-64590

Current ABI jar generation includes not only public classes but internal and in some instances private which I belives can lead to unnecessary build invalidations.

As far as I can tell we would need to include optional configuration of the jvm-abi plugin in or around here

You might expect something along these lines in that file

plugin(plugins.jvmAbiGen) {
  flag("outputDir", directories.abiClasses)
  if(task.info.publicOnlyAbiJar) {
    flag("treatInternalAsPrivate", "true")
    flag("removePrivateClasses", "true")
   }
}

I think it would make sense to bundle both these plugin options behind one experimental flag on the rule.

Your thoughts on this?

Im currently exploring how this might look in the codebase but progress is slow (however I do have a failing test for the core part of this)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions