Windows still seeing LAUNCHER ERROR in v2.1.3 (follow-on to #1274)

[crt-31]

This is a ticket to capture the follow-on work related to #1274 issue that was described here:

#1274 (comment)

Unfortunately there were some things missing for this, see bazel-contrib/rules_jvm_external#1297 (comment)

Basically jdeps_merger in src/main/kotlin/BUILD.release.bazel also needs to be updated: https://github.com/bazelbuild/rules_kotlin/blob/master/src/main/kotlin/BUILD.release.bazel#L77-L85

Otherwise the same error LAUNCHER ERROR: Rlocation failed on ... occurs with the released version of the rules

I am still seeing this error on v2.1.3:

LAUNCHER ERROR: Rlocation failed on _main/external/rules_kotlin~~rules_kotlin_extensions~com_github_jetbrains_kotlin_git/lib/annotations-13.0.jar, path doesn't exist in MANIFEST file

[redsun82]

HI @crt-31, is there any follow up on this? We're seeing this problem, and we tried to patch the released BUILD.bazel with the KOTLIN_STDLIBS changes that were carried on on the non-release BUILD file, but we're still seeing this error. Incidentally, rules_kotlin~~rules_kotlin_extensions~com_github_jetbrains_kotlin_git/lib/annotations-13.0.jar gets included in the MANIFEST file, just not with the _main/external prefix. I'm starting to wonder if it's not a bug in the java launcher.

[redsun82]

We just found out that additionally to the BUILD.bazel patching that is mentioned in the comment linked here (for example, this patch, we were only able to also get past this problem by providing the --legacy_external_runfiles bazel flag. That will make that _main/external prefix work, as those files will be added under that prefix inside the runfiles. It would be good though if rules_kotlin (or rules_java?) was able to work without that flag on windows.

[smowton]

I've written up the situation @redsun82 describes in a bit more detail at #1309