virtinst: prefer SATA bus for bhyve

Choose SATA as a default bus for bhyve as it doesn't support IDE.

Reviewed-by: Cole Robinson <[email protected]>
Signed-off-by: Roman Bogorodskiy <[email protected]>

Author: novel

tests/data/cli/compare/virt-install-bhyve-default-f27.xml

@@ -18,7 +18,7 @@
     <emulator>bhyve</emulator>
     <disk type="file" device="disk">
       <source file="/var/lib/libvirt/images/foobhyve.img"/>
-      <target dev="hda" bus="ide"/>
+      <target dev="sda" bus="sata"/>
     </disk>
     <interface type="bridge">
       <source bridge="testsuitebr0"/>

virtinst/connection.py

@@ -408,6 +408,8 @@ def is_container_only(self):
     def is_vz(self):
         return (self._uriobj.scheme.startswith("vz") or
                 self._uriobj.scheme.startswith("parallels"))
+    def is_bhyve(self):
+        return self._uriobj.scheme.startswith("bhyve")
 
 
     #########################

virtinst/devices/disk.py

@@ -972,6 +972,9 @@ def _default_bus(self, guest):
             return "sd"
         if guest.os.is_q35():
             return "sata"
+        if self.conn.is_bhyve():
+            # IDE bus is not supported by bhyve
+            return "sata"
         return "ide"
 
     def set_defaults(self, guest):