Skip to content

Commit 37e3c51

Browse files
committed
Switch to new parent POM.
1 parent add1aa5 commit 37e3c51

File tree

2 files changed

+8
-20
lines changed

2 files changed

+8
-20
lines changed

pom.xml

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<parent>
55
<groupId>org.jenkins-ci.plugins</groupId>
66
<artifactId>plugin</artifactId>
7-
<version>1.596.1</version>
7+
<version>2.3</version>
88
</parent>
99
<artifactId>docker-workflow</artifactId>
1010
<version>1.4-SNAPSHOT</version>
@@ -28,8 +28,8 @@
2828
</scm>
2929

3030
<properties>
31+
<jenkins.version>1.596.1</jenkins.version>
3132
<workflow.version>1.7</workflow.version>
32-
<maven-hpi-plugin.version>1.112</maven-hpi-plugin.version>
3333
</properties>
3434
<repositories>
3535
<repository>
@@ -104,17 +104,4 @@
104104
<scope>test</scope>
105105
</dependency>
106106
</dependencies>
107-
<build>
108-
<plugins>
109-
<plugin>
110-
<groupId>org.codehaus.mojo</groupId>
111-
<artifactId>findbugs-maven-plugin</artifactId>
112-
<version>3.0.2</version>
113-
<configuration>
114-
<xmlOutput>true</xmlOutput>
115-
<failOnError>false</failOnError>
116-
</configuration>
117-
</plugin>
118-
</plugins>
119-
</build>
120107
</project>

src/test/java/org/jenkinsci/plugins/docker/workflow/WithContainerStepTest.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@
2727
import hudson.tools.ToolProperty;
2828
import java.util.Collections;
2929
import org.jenkinsci.plugins.docker.commons.tools.DockerTool;
30-
import org.jenkinsci.plugins.workflow.BuildWatcher;
31-
import org.jenkinsci.plugins.workflow.JenkinsRuleExt;
3230
import org.jenkinsci.plugins.workflow.cps.CpsFlowDefinition;
3331
import org.jenkinsci.plugins.workflow.job.WorkflowJob;
3432
import org.jenkinsci.plugins.workflow.job.WorkflowRun;
@@ -37,13 +35,16 @@
3735
import org.junit.ClassRule;
3836
import org.junit.Test;
3937
import org.junit.Rule;
38+
import org.junit.rules.TemporaryFolder;
4039
import org.junit.runners.model.Statement;
40+
import org.jvnet.hudson.test.BuildWatcher;
4141
import org.jvnet.hudson.test.RestartableJenkinsRule;
4242

4343
public class WithContainerStepTest {
4444

4545
@ClassRule public static BuildWatcher buildWatcher = new BuildWatcher();
4646
@Rule public RestartableJenkinsRule story = new RestartableJenkinsRule();
47+
@Rule public TemporaryFolder tmp = new TemporaryFolder();
4748

4849
@Test public void configRoundTrip() {
4950
story.addStep(new Statement() {
@@ -88,9 +89,9 @@ public class WithContainerStepTest {
8889
" }\n" +
8990
"}", true));
9091
WorkflowRun b = p.scheduleBuild2(0).waitForStart();
91-
JenkinsRuleExt.waitForMessage("sleeping now", b);
92+
story.j.waitForMessage("sleeping now", b);
9293
b.doStop();
93-
story.j.assertBuildStatus(Result.ABORTED, JenkinsRuleExt.waitForCompletion(b));
94+
story.j.assertBuildStatus(Result.ABORTED, story.j.waitForCompletion(b));
9495
story.j.assertLogContains("script returned exit code 99", b);
9596
}
9697
});
@@ -134,7 +135,7 @@ public class WithContainerStepTest {
134135
SemaphoreStep.success("wait/1", null);
135136
WorkflowJob p = story.j.jenkins.getItemByFullName("prj", WorkflowJob.class);
136137
WorkflowRun b = p.getLastBuild();
137-
story.j.assertLogContains("Require method GET POST OPTIONS", story.j.assertBuildStatusSuccess(JenkinsRuleExt.waitForCompletion(b)));
138+
story.j.assertLogContains("Require method GET POST OPTIONS", story.j.assertBuildStatusSuccess(story.j.waitForCompletion(b)));
138139
}
139140
});
140141
}

0 commit comments

Comments
 (0)