Skip to content
This repository was archived by the owner on Sep 26, 2024. It is now read-only.

[InputTime] Change range of hour selection #101

Closed
nieldlr opened this issue Jun 13, 2017 · 1 comment
Closed

[InputTime] Change range of hour selection #101

nieldlr opened this issue Jun 13, 2017 · 1 comment
Labels

Comments

@nieldlr
Copy link

nieldlr commented Jun 13, 2017

Heya team,

Colin noticed something odd with 12 hour time with the hour range. It goes from 12 -> 11. This feels a bit odd.

screen shot 2017-06-13 at 1 52 54 pm

If you look at other parts of the app, we use 1->12 regardless of AM or PM.
screen shot 2017-06-13 at 12 40 42 pm
I'm curious if we could make this change? It feels a bit more intuitive and makes things consistent too.

I looked into getting this fix in there, but got a bit stumped on the genArray function in InputTime to get this to work. Any ideas on how how to get this working and not create any breaking changes for the DateTimeForm (in buffer-web-components)?

cc @hharnisc & @stevemdixon

@stphndxn stphndxn added the bug label Jun 13, 2017
@stphndxn stphndxn changed the title Change range for InputTime's hour selection [InputTime] Change range of hour selection Jun 15, 2017
@nieldlr
Copy link
Author

nieldlr commented Jun 22, 2017

Chatted with @stevemdixon & @colinscape. We're going to stick with times starting at 12 :). Reference here: https://en.wikipedia.org/wiki/12-hour_clock

It might be useful to update the ranges for our other parts of our app to be consistent with this component in the future :)

@nieldlr nieldlr closed this as completed Jun 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants