Skip to content
This repository was archived by the owner on Sep 26, 2024. It is now read-only.

Safari rendering issue on all <Button noStyle /> #99

Closed
stphndxn opened this issue Jun 8, 2017 · 2 comments
Closed

Safari rendering issue on all <Button noStyle /> #99

stphndxn opened this issue Jun 8, 2017 · 2 comments
Labels

Comments

@stphndxn
Copy link
Contributor

stphndxn commented Jun 8, 2017

All components that use the noStyle config of the Button component don't render any text in Safari when using lineHeight: 0. Setting lineHeight like this allows instances of Button with an Icon as its only child to have Icon perfectly center. It feels like we might need to explore an alternative solution with perhaps a last resort being a child-type specific config of Button.

@stphndxn
Copy link
Contributor Author

stphndxn commented Jun 8, 2017

@hamstu has a fix in place for this one. Perhaps we could include the solution for <Button><Icon /></Button> and include it in that same PR, @hharnisc?

@hharnisc
Copy link
Contributor

Gonna close this one for now since there was a fix put in place for this by @hamstu! Might be worth creating another issue though for the centering for the noStyle Button

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants