Skip to content

Commit cbec184

Browse files
committed
Fix: don't push undefined into middleware
1 parent f94ff5f commit cbec184

File tree

2 files changed

+13
-19
lines changed

2 files changed

+13
-19
lines changed

app/javascript/reducers/initialState.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { combineReducers } from "redux";
21
import { persistCombineReducers } from "redux-persist";
32
import storage from "redux-persist/es/storage";
43
import { LOAD_INITIAL_STATE } from "../constants";

app/javascript/store/index.js

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,31 @@
1-
import React from 'react';
1+
import React from "react";
22

3-
import { createStore, compose, applyMiddleware } from 'redux';
4-
import { createDevTools } from 'redux-devtools';
5-
import { createLogger } from 'redux-logger';
3+
import { createStore, compose, applyMiddleware } from "redux";
4+
import { createDevTools } from "redux-devtools";
5+
import { createLogger } from "redux-logger";
66

7-
import LogMonitor from 'redux-devtools-log-monitor';
8-
import DockMonitor from 'redux-devtools-dock-monitor';
7+
import LogMonitor from "redux-devtools-log-monitor";
8+
import DockMonitor from "redux-devtools-dock-monitor";
99

10-
import { persistStore } from 'redux-persist';
11-
import storage from 'redux-persist/es/storage';
10+
import { persistStore } from "redux-persist";
1211

1312
const logger = createLogger();
1413

1514
const DevToolsContainer = createDevTools(
16-
<DockMonitor
17-
toggleVisibilityKey='ctrl-h'
18-
changePositionKey='ctrl-q'
19-
>
15+
<DockMonitor toggleVisibilityKey="ctrl-h" changePositionKey="ctrl-q">
2016
<LogMonitor />
2117
</DockMonitor>
2218
);
2319

2420
let composition = [];
2521

26-
if (process.env.NODE_ENV === 'production') {
22+
if (process.env.NODE_ENV === "production") {
2723
// Any production-specific reducers
2824
} else {
2925
composition.push(applyMiddleware(logger));
30-
composition.push(
31-
window.__REDUX_DEVTOOLS_EXTENSION__
32-
&& window.__REDUX_DEVTOOLS_EXTENSION__()
33-
);
26+
if (window.__REDUX_DEVTOOLS_EXTENSION__) {
27+
composition.push(window.__REDUX_DEVTOOLS_EXTENSION__());
28+
}
3429
}
3530

3631
function initializeStore(rootReducer) {
@@ -39,4 +34,4 @@ function initializeStore(rootReducer) {
3934
return { store, persistor };
4035
}
4136

42-
export { DevToolsContainer, initializeStore };
37+
export { DevToolsContainer, initializeStore };

0 commit comments

Comments
 (0)