eslint & related fixes

The project previously had jshint.. but it was misconfigured so that it didn't actually check any of the source.
So.. enabling it reported 200+ errors.

I installed eslint partially for the --fix option because it autofixes half of the issues (try npm run autofix ;)
After that, I fixed the remaining issues, and swapped jshint out for eslint.

Author: nfriedly

.eslintignore

@@ -0,0 +1,4 @@
+# http://eslint.org/docs/user-guide/configuring#ignoring-files-and-directories
+jsdoc/
+doc/
+coverage/

.eslintrc.js

@@ -0,0 +1,216 @@
+module.exports = {
+    "env": {
+        "node": true
+    },
+    "extends": "eslint:recommended",
+    "rules": {
+        "accessor-pairs": 2,
+        "array-bracket-spacing": 0,
+        "array-callback-return": 2,
+        "arrow-body-style": 2,
+        "arrow-parens": 2,
+        "arrow-spacing": 2,
+        "block-scoped-var": 2,
+        "block-spacing": 0,
+        "brace-style": 0,
+        "callback-return": 0,
+        "camelcase": 0,
+        "comma-dangle": [
+            2,
+            "only-multiline"
+        ],
+        "comma-spacing": 0,
+        "comma-style": [
+            2,
+            "last"
+        ],
+        "complexity": 2,
+        "computed-property-spacing": [
+            2,
+            "never"
+        ],
+        "consistent-return": 0,
+        "consistent-this": 0,
+        "curly": 0,
+        "default-case": 2,
+        "dot-location": [
+            2,
+            "property"
+        ],
+        "dot-notation": 0,
+        "eol-last": 0,
+        "eqeqeq": 0,
+        "func-names": 0,
+        "func-style": 0,
+        "generator-star-spacing": 2,
+        "global-require": 0,
+        "guard-for-in": 2,
+        "handle-callback-err": 0,
+        "id-blacklist": 2,
+        "id-length": 0,
+        "id-match": 2,
+        "indent": 0,
+        "init-declarations": 0,
+        "jsx-quotes": 2,
+        "key-spacing": 0,
+        "keyword-spacing": 0,
+        "linebreak-style": [
+            2,
+            "unix"
+        ],
+        "lines-around-comment": 0,
+        "max-depth": 2,
+        "max-len": 0,
+        "max-nested-callbacks": 2,
+        "max-params": 0,
+        "new-cap": 2,
+        "new-parens": 2,
+        "newline-after-var": 0,
+        "newline-per-chained-call": 0,
+        "no-alert": 2,
+        "no-array-constructor": 2,
+        "no-bitwise": 2,
+        "no-caller": 2,
+        "no-catch-shadow": 2,
+        "no-confusing-arrow": 2,
+        "no-continue": 2,
+        "no-div-regex": 2,
+        "no-else-return": 0,
+        "no-empty-function": 0,
+        "no-eq-null": 2,
+        "no-eval": 2,
+        "no-extend-native": 2,
+        "no-extra-bind": 2,
+        "no-extra-label": 2,
+        "no-extra-parens": 0,
+        "no-floating-decimal": 2,
+        "no-implicit-coercion": 2,
+        "no-implicit-globals": 2,
+        "no-implied-eval": 2,
+        "no-inline-comments": 0,
+        "no-inner-declarations": [
+            2,
+            "functions"
+        ],
+        "no-invalid-this": 0,
+        "no-iterator": 2,
+        "no-label-var": 2,
+        "no-labels": 2,
+        "no-lone-blocks": 2,
+        "no-lonely-if": 0,
+        "no-loop-func": 2,
+        "no-magic-numbers": 0,
+        "no-mixed-requires": 2,
+        "no-multi-spaces": 0,
+        "no-multi-str": 2,
+        "no-multiple-empty-lines": 0,
+        "no-native-reassign": 2,
+        "no-negated-condition": 0,
+        "no-nested-ternary": 2,
+        "no-new": 2,
+        "no-new-func": 2,
+        "no-new-object": 2,
+        "no-new-require": 2,
+        "no-new-wrappers": 2,
+        "no-octal-escape": 2,
+        "no-param-reassign": 0,
+        "no-path-concat": 0,
+        "no-plusplus": [
+            2,
+            {
+                "allowForLoopAfterthoughts": true
+            }
+        ],
+        "no-process-env": 0,
+        "no-process-exit": 2,
+        "no-proto": 2,
+        "no-restricted-imports": 2,
+        "no-restricted-modules": 2,
+        "no-restricted-syntax": 2,
+        "no-return-assign": 2,
+        "no-script-url": 2,
+        "no-self-compare": 2,
+        "no-sequences": 2,
+        "no-shadow": 0,
+        "no-shadow-restricted-names": 2,
+        "no-spaced-func": 0,
+        "no-sync": 0,
+        "no-ternary": 0,
+        "no-throw-literal": 2,
+        "no-trailing-spaces": [
+            2,
+            {
+                "skipBlankLines": true
+            }
+        ],
+        "no-undef-init": 2,
+        "no-undefined": 0,
+        "no-underscore-dangle": 0,
+        "no-unmodified-loop-condition": 2,
+        "no-unneeded-ternary": 2,
+        "no-unused-expressions": 0,
+        "no-use-before-define": 0,
+        "no-useless-call": 2,
+        "no-useless-concat": 2,
+        "no-useless-constructor": 2,
+        "no-var": 0,
+        "no-void": 2,
+        "no-warning-comments": 0,
+        "no-whitespace-before-property": 2,
+        "no-with": 2,
+        "object-curly-spacing": 0,
+        "object-shorthand": 0,
+        "one-var": 0,
+        "one-var-declaration-per-line": 2,
+        "operator-assignment": [
+            2,
+            "always"
+        ],
+        "operator-linebreak": 2,
+        "padded-blocks": 0,
+        "prefer-arrow-callback": 0,
+        "prefer-const": 2,
+        "prefer-reflect": 0,
+        "prefer-rest-params": 0,
+        "prefer-spread": 2,
+        "prefer-template": 0,
+        "quote-props": 0,
+        "quotes": 0,
+        "radix": 2,
+        "require-jsdoc": 0,
+        "require-yield": 2,
+        "semi": 0,
+        "semi-spacing": [
+            2,
+            {
+                "after": true,
+                "before": false
+            }
+        ],
+        "sort-imports": 2,
+        "sort-vars": 0,
+        "space-before-blocks": 0,
+        "space-before-function-paren": 0,
+        "space-in-parens": 0,
+        "space-infix-ops": 0,
+        "space-unary-ops": [
+            2,
+            {
+                "nonwords": false,
+                "words": false
+            }
+        ],
+        "spaced-comment": 0,
+        "strict": 0,
+        "template-curly-spacing": 2,
+        "valid-jsdoc": 0,
+        "vars-on-top": 0,
+        "wrap-iife": 2,
+        "wrap-regex": 0,
+        "yield-star-spacing": 2,
+        "yoda": [
+            2,
+            "never"
+        ]
+    }
+};

examples/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  "env": {
+    "node": true
+  },
+  "extends": "../.eslintrc.js",
+  "rules": {
+    "no-console": 0
+  }
+};

examples/alchemy_language.v1.js

@@ -15,4 +15,4 @@ alchemy_language.sentiment(params, function (err, response) {
     console.log('error:', err);
   else
     console.log(JSON.stringify(response, null, 2));
-});
+});

examples/alchemy_vision.v1.js

@@ -1,4 +1,5 @@
 'use strict';
+/*eslint no-redeclare: 0*/
 
 var watson = require('watson-developer-cloud');
 var fs = require('fs');
@@ -9,7 +10,7 @@ var alchemy_vision = watson.alchemy_vision({
 
 // Image keywords
 var params = {
-  image: fs.createReadStream('resources/car.png')
+  image: fs.createReadStream('resources/car.png'),
   forceShowAll: 1 // Includes lower confidence tags
 };
 
@@ -33,7 +34,7 @@ alchemy_vision.getImageKeywords(params, function (err, keywords) {
 
 // Face recognize
 var params = {
-  knowledgeGraph: 1 // Include knowledge graph information in the the results.
+  knowledgeGraph: 1, // Include knowledge graph information in the the results.
   url: 'https://upload.wikimedia.org/wikipedia/commons/0/00/Scarlett_Johansson_-_Captain_America_2_press_conference_%28retouched%29_2.jpg'
 };