Skip to content

Commit 16a38a6

Browse files
committed
fixed custom select dialog menu transition issues by preceding backward through history. This tightly couples the closing of custom select dialog menus to our hash change history implementation because of how it handles dialogs in dialogs.
1 parent 01c40c2 commit 16a38a6

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

js/jquery.mobile.forms.select.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -554,8 +554,10 @@ $.widget( "mobile.selectmenu", $.mobile.widget, {
554554
}
555555

556556
if(self.menuType == "page"){
557-
$.mobile.changePage([self.menuPage,self.thisPage], 'pop', true, false);
558-
self.menuPage.one("pagehide", focusButton);
557+
// doesn't solve the possible issue with calling change page
558+
// where the objects don't define data urls which prevents dialog key
559+
// stripping - changePage has incoming refactor
560+
window.history.back();
559561
}
560562
else{
561563
self.screen.addClass( "ui-screen-hidden" );

0 commit comments

Comments
 (0)