Skip to content

Simultaneous addition of members results in missing keys #6791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
link2xt opened this issue Apr 9, 2025 · 0 comments
Open

Simultaneous addition of members results in missing keys #6791

link2xt opened this issue Apr 9, 2025 · 0 comments
Labels
bug Something is not working

Comments

@link2xt
Copy link
Collaborator

link2xt commented Apr 9, 2025

Let's say A and B are part of the group. Simultaneously, e.g. while being offline, A adds C and B adds D. Now the group consists of A, B, C and D, but C and D don't see each other yet because "member added" message for C does not contain D and vice versa. Then let's say A writes something to the group. Both C and D will learn about the full group member list from this message, but A will not gossip the keys for C and D, so C and D will now see each other as a member without a key.

This is the current state because we track a single gossip timestamp for each chat and will gossip the keys only two days later or if someone is added. With #6787 we will track the gossip per chat and fingerprint of the gossiped key, but will not track who have seen which keys.

One way to fix this case would be to track the gossip of each key per recipient. Since A did not see the key of C gossiped to D and key of D gossiped to C, A should gossip the keys for C and D.

Another option is to not fix this problem as it happens rarely, but allow sending key requests, so C will request the key of D and D will request the key of C when they send a message to the chat.

@link2xt link2xt added the bug Something is not working label Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

1 participant