Skip to content

Commit 06b36c9

Browse files
committed
Explain more details
1 parent 565f3c3 commit 06b36c9

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/main/java/fi/csc/chipster/filestorage/FileServlet.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,14 @@ protected void doGetFile(HttpServletRequest request, HttpServletResponse respons
167167

168168
if (request.isAsyncStarted()) {
169169
/*
170-
* By default the async timeout is enabled. Everything works, but onTimeout()
171-
* listener is called after 30 seconds and jetty logs an IllegalStateException
172-
* in ServletChannelState.java.
170+
* By default the async timeout is enabled. Amost everything works, but
171+
* onTimeout() listener is called after 30 seconds and jetty logs an
172+
* IllegalStateException in ServletChannelState.java.
173+
*
174+
* This caused problems only when > 4 GiB file was uploaded to file-storage
175+
* and then moved to S3. The request to delete the file from file-storage got
176+
* stuck. Perhaps because the async timeout had left a connection to a bad
177+
* state.
173178
*
174179
* Apparently we are supposed to turn of timeout when handling large files:
175180
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=447472 . Let's see if we have

0 commit comments

Comments
 (0)