Merge pull request rtfeldman#561 from Confidenceman02/master

fix: Runtime exception when using css in SVG elements

Author: rtfeldman

elm.json

@@ -36,4 +36,4 @@
     "test-dependencies": {
         "elm-explorations/test": "1.2.2 <= v < 2.0.0"
     }
-}
+}

examples/html-styled/Main.elm

@@ -6,6 +6,8 @@ import Html
 import Html.Styled exposing (..)
 import Html.Styled.Attributes exposing (css, href, src)
 import Html.Styled.Events exposing (onClick)
+import Svg.Styled as StyledSvg
+import Svg.Styled.Attributes as SvgAttribs
 
 
 {-| A logo image, with inline styles that change on hover.
@@ -82,6 +84,7 @@ view model =
     nav []
         [ img [ src "assets/backdrop.jpg", css [ width (pct 100) ] ] []
         , btn [ onClick DoSomething ] [ text "Click me!" ]
+        , StyledSvg.svg [ SvgAttribs.css [], SvgAttribs.width "100", SvgAttribs.height "100" ] [ StyledSvg.circle [ SvgAttribs.cx "50", SvgAttribs.cy "50", SvgAttribs.r "40" ] [] ]
         ]
 
 

examples/html-styled/elm.json

@@ -7,26 +7,26 @@
     "elm-version": "0.19.0",
     "dependencies": {
         "direct": {
-            "Skinney/murmur3": "2.0.7",
             "elm/browser": "1.0.0",
             "elm/core": "1.0.0",
             "elm/html": "1.0.0",
             "elm/json": "1.0.0",
-            "rtfeldman/elm-hex": "1.0.0",
             "elm/virtual-dom": "1.0.0",
-            "elm-explorations/markdown": "1.0.0"
+            "elm-explorations/markdown": "1.0.0",
+            "robinheghan/murmur3": "1.0.0",
+            "rtfeldman/elm-hex": "1.0.0"
         },
         "indirect": {
             "elm/time": "1.0.0",
-            "elm/url": "1.0.0",
-            "elm/parser": "1.0.0"
+            "elm/url": "1.0.0"
         }
     },
     "test-dependencies": {
         "direct": {
             "elm-explorations/test": "1.0.0"
         },
         "indirect": {
+            "elm/parser": "1.0.0",
             "elm/random": "1.0.0"
         }
     }

package.json

@@ -44,9 +44,9 @@
     "tmp": "0.0.28"
   },
   "devDependencies": {
-    "elm-test": "0.18.13-beta",
+    "chai": "3.4.1",
     "elm-format": "0.8.0",
-    "chai": "3.4.1"
+    "elm-test": "^0.19.1-revision7"
   },
   "engineStrict": true,
   "engines": {

src/VirtualDom/Styled.elm

@@ -492,10 +492,10 @@ extractUnstyledAttribute styles (Attribute val isCssStyles cssTemplate) =
     if isCssStyles then
         case Dict.get cssTemplate styles of
             Just classname ->
-                VirtualDom.property "className" (Json.Encode.string classname)
+                VirtualDom.attribute "className" classname
 
             Nothing ->
-                VirtualDom.property "className" (Json.Encode.string "_unstyled")
+                VirtualDom.attribute "className" "_unstyled"
 
     else
         val