Skip to content

Commit d588e14

Browse files
authored
Merge pull request sclorg#113 from jim-minter/issue16726
remove expose annotations from quickstarts and add bindable: false
2 parents b75ed75 + dd4a001 commit d588e14

File tree

3 files changed

+9
-15
lines changed

3 files changed

+9
-15
lines changed

openshift/templates/django-postgresql-persistent.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
"openshift.io/long-description": "This template defines resources needed to develop a Django based application, including a build configuration, application deployment configuration, and database deployment configuration.",
1212
"openshift.io/provider-display-name": "Red Hat, Inc.",
1313
"openshift.io/documentation-url": "https://github.com/openshift/django-ex",
14-
"openshift.io/support-url": "https://access.redhat.com"
14+
"openshift.io/support-url": "https://access.redhat.com",
15+
"template.openshift.io/bindable": "false"
1516
}
1617
},
1718
"message": "The following service(s) have been created in your project: ${NAME}, ${DATABASE_SERVICE_NAME}.\n\nFor more information about using this template, including OpenShift considerations, see https://github.com/openshift/django-ex/blob/master/README.md.",
@@ -58,10 +59,7 @@
5859
"kind": "Route",
5960
"apiVersion": "v1",
6061
"metadata": {
61-
"name": "${NAME}",
62-
"annotations": {
63-
"template.openshift.io/expose-uri": "http://{.spec.host}{.spec.path}"
64-
}
62+
"name": "${NAME}"
6563
},
6664
"spec": {
6765
"host": "${APPLICATION_DOMAIN}",

openshift/templates/django-postgresql.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
"openshift.io/long-description": "This template defines resources needed to develop a Django based application, including a build configuration, application deployment configuration, and database deployment configuration. The database is stored in non-persistent storage, so this configuration should be used for experimental purposes only.",
1212
"openshift.io/provider-display-name": "Red Hat, Inc.",
1313
"openshift.io/documentation-url": "https://github.com/openshift/django-ex",
14-
"openshift.io/support-url": "https://access.redhat.com"
14+
"openshift.io/support-url": "https://access.redhat.com",
15+
"template.openshift.io/bindable": "false"
1516
}
1617
},
1718
"message": "The following service(s) have been created in your project: ${NAME}, ${DATABASE_SERVICE_NAME}.\n\nFor more information about using this template, including OpenShift considerations, see https://github.com/openshift/django-ex/blob/master/README.md.",
@@ -58,10 +59,7 @@
5859
"kind": "Route",
5960
"apiVersion": "v1",
6061
"metadata": {
61-
"name": "${NAME}",
62-
"annotations": {
63-
"template.openshift.io/expose-uri": "http://{.spec.host}{.spec.path}"
64-
}
62+
"name": "${NAME}"
6563
},
6664
"spec": {
6765
"host": "${APPLICATION_DOMAIN}",

openshift/templates/django.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
"openshift.io/long-description": "This template defines resources needed to develop a Django based application, including a build configuration and application deployment configuration. It does not include a database.",
1212
"openshift.io/provider-display-name": "Red Hat, Inc.",
1313
"openshift.io/documentation-url": "https://github.com/openshift/django-ex",
14-
"openshift.io/support-url": "https://access.redhat.com"
14+
"openshift.io/support-url": "https://access.redhat.com",
15+
"template.openshift.io/bindable": "false"
1516
}
1617
},
1718
"labels": {
@@ -55,10 +56,7 @@
5556
"kind": "Route",
5657
"apiVersion": "v1",
5758
"metadata": {
58-
"name": "${NAME}",
59-
"annotations": {
60-
"template.openshift.io/expose-uri": "http://{.spec.host}{.spec.path}"
61-
}
59+
"name": "${NAME}"
6260
},
6361
"spec": {
6462
"host": "${APPLICATION_DOMAIN}",

0 commit comments

Comments
 (0)