Skip to content

Commit dd98b88

Browse files
committed
Fix 'Align MimeMappings with Tomcat's defaults'
Update COMMON_MAPPINGS to align with the properties file and change the test so that it consistently works. See spring-projectsgh-32101
1 parent fe1ffff commit dd98b88

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/server/MimeMappings.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,14 +261,14 @@ static final class DefaultMimeMappings extends MimeMappings {
261261
mappings.add("jpg", "image/jpeg");
262262
mappings.add("js", "application/javascript");
263263
mappings.add("json", "application/json");
264-
mappings.add("otf", "application/x-font-opentype");
264+
mappings.add("otf", "font/otf");
265265
mappings.add("pdf", "application/pdf");
266266
mappings.add("png", "image/png");
267267
mappings.add("ps", "application/postscript");
268268
mappings.add("tar", "application/x-tar");
269269
mappings.add("tif", "image/tiff");
270270
mappings.add("tiff", "image/tiff");
271-
mappings.add("ttf", "application/x-font-ttf");
271+
mappings.add("ttf", "font/ttf");
272272
mappings.add("txt", "text/plain");
273273
mappings.add("xht", "application/xhtml+xml");
274274
mappings.add("xhtml", "application/xhtml+xml");

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/server/MimeMappingsTests.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,9 +174,11 @@ void iterateOnDefaultMimeMappingsLoadsMappings() {
174174

175175
@Test
176176
void commonMappingsAreSubsetOfAllMappings() {
177+
MimeMappings defaultMappings = new DefaultMimeMappings();
177178
MimeMappings commonMappings = (MimeMappings) ReflectionTestUtils.getField(DefaultMimeMappings.class, "COMMON");
179+
defaultMappings.getAll();
178180
for (Mapping commonMapping : commonMappings) {
179-
assertThat(MimeMappings.DEFAULT.get(commonMapping.getExtension())).isEqualTo(commonMapping.getMimeType());
181+
assertThat(defaultMappings.get(commonMapping.getExtension())).isEqualTo(commonMapping.getMimeType());
180182
}
181183
}
182184

0 commit comments

Comments
 (0)