Skip to content

Tests fail with byte-streams 0.2.1-alpha2 and up #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KingMob opened this issue May 5, 2022 · 0 comments
Open

Tests fail with byte-streams 0.2.1-alpha2 and up #10

KingMob opened this issue May 5, 2022 · 0 comments

Comments

@KingMob
Copy link
Collaborator

KingMob commented May 5, 2022

I went to bump up byte-streams, since 0.2.0 is quite old, and started seeing a lot of failures in the concat-roundtrip-compressors test like:

FAIL in (concat-roundtrip-compressors) (byte_transforms_simple_check.clj:51)
expected: {:result true}
  actual: {:shrunk {:total-nodes-visited 186, :depth 0, :pass? false, :result false, :result-data nil, :time-shrinking-ms 406, :smallest [#object["[B" 0x3305897c "[B@3305897c"] 1 :gzip]}, :failed-after-ms 1151, :num-tests 1888, :seed 1651736988115, :fail [#object["[B" 0x3305897c "[B@3305897c"] 1 :gzip], :result false, :result-data nil, :failing-size 87, :pass? false, :test-var "concat-roundtrip-compressors"}

The only change in byte-streams from 0.2.1-alpha1 to 0.2.1-alpha2 was clj-commons/byte-streams@4750b5b.

This is almost certainly a byte-streams bug, possibly related to clj-commons/byte-streams#37, given the code change, but this issue serves as a reminder to revisit when byte-streams is fixed.

@KingMob KingMob assigned KingMob and unassigned KingMob May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant