Skip to content

Commit ec9db54

Browse files
committed
modified unit testsa nd integration tests for evaluation
1 parent a19db46 commit ec9db54

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

tests/integration/test_evaluate_api.py

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,14 +95,19 @@ def test_evaluate_with_invalid_model(mock_qa_file):
9595
"output_key": "Prompt",
9696
"output_value": "Completion"
9797
}
98-
# Patch create_handler so that it raises a ModelHandlerError for an invalid model.
98+
9999
from app.core.exceptions import ModelHandlerError
100-
def dummy_handler(prompt):
101-
raise ModelHandlerError("Invalid model identifier: invalid.model")
102-
with patch('app.services.evaluator_service.create_handler') as mock_handler:
103-
mock_handler.return_value.generate_response.side_effect = dummy_handler
100+
101+
# Patch create_handler to raise ModelHandlerError
102+
with patch('app.services.evaluator_service.create_handler') as mock_create:
103+
mock_create.side_effect = ModelHandlerError("Invalid model identifier: invalid.model")
104104
response = client.post("/synthesis/evaluate", json=request_data)
105-
# Expect a 400 (or similar) error response.
105+
106+
# Print for debugging
107+
print(f"Response status: {response.status_code}")
108+
print(f"Response content: {response.json()}")
109+
110+
# Expect a 400 or 500 error response
106111
assert response.status_code in [400, 500]
107112
res_json = response.json()
108113
assert "error" in res_json

tests/unit/test_evaluator_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def test_evaluate_single_pair():
6161
def test_evaluate_results_with_error():
6262
fake_json = '[{"Seeds": "python_basics", "Prompt": "What is Python?", "Completion": "Python is a programming language"}]'
6363
class DummyHandler:
64-
def generate_response(self, prompt):
64+
def generate_response(self, prompt, **kwargs): # Accept any keyword arguments
6565
raise ModelHandlerError("Test error")
6666
with patch('app.services.evaluator_service.os.path.exists', return_value=True), \
6767
patch('builtins.open', new=lambda f, mode, *args, **kwargs: StringIO(fake_json)), \

0 commit comments

Comments
 (0)