🛠️ CHORE: Better organise esbuild plugins for Pages

[CarmenPopoviciu]

Which Cloudflare product(s) does this pertain to?

Wrangler core

What version(s) of the tool(s) are you using?

3.63.1

What version of Node are you using?

18.20.0

What operating system and version are you using?

MacOS Sonoma 14.4.1

Describe the Bug

wrangler uses a bunch of esbuild plugins for bundling & building both Workers proper and Workers for Pages projects. These plugins are spread all over the place, and tend to lack descriptions abt what it is that they do. Furthermore, these plugins tend to be added cumulatively by different internal APIs, at different points in time in the API invocation chain. This makes them

• hard to track down
• hard to reason abt
• hard to understand which plugin was added where and by which API
• hard to get an overview of which plugins are used for wrangler proper, and which for wrangler pages

It would be great if we could better organise these plugins in our codebase, in order to gain more insight into what is actually "out there" 🌌, what is used where and for what, and just do some spring cleaning overall :meouw-wow:

Please provide a link to a minimal reproduction

No response

Please provide any relevant error logs

No response

[emily-shen]

@CarmenPopoviciu having a look now these seem to all be in either /deployment-bundle/esbuild-plugins, plus one in pages/functions/buildWorker.ts

Has this been dealt with already, have i missed a bunch of plugins or did you have some other organisation in mind?

[CarmenPopoviciu]

Seems like this is mostly an issue with how Pages organises its esbuild plugins. See here and here for example, where some plugins are declared inline. IMO it'd be tidier to extract those under smth like /pages/esbuild-plugins like wrangler proper does in https://github.com/cloudflare/workers-sdk/tree/main/packages/wrangler/src/deployment-bundle/esbuild-plugins

[petebacondarwin]

Since Pages is mostly deprecated in favor of Workers + Assets, we are not likely to put effort into refactoring this code.